|
|
Created:
3 years, 6 months ago by Tom Anderson Modified:
3 years, 6 months ago Reviewers:
Lei Zhang CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll buildtools to b53a03
This roll includes 3 revisions [1] and is purely to make sure those
revisions didn't break anything.
[1] https://chromium.googlesource.com/chromium/buildtools/+log/31d4daa..b53a03
BUG=593874
R=thestig@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng
Review-Url: https://codereview.chromium.org/2932783002
Cr-Commit-Position: refs/heads/master@{#478204}
Committed: https://chromium.googlesource.com/chromium/src/+/e89683d4ca3cc61fed5984c234bab3f1dc6c3ef0
Patch Set 1 #Messages
Total messages: 21 (14 generated)
Description was changed from ========== Roll buildtools to b53a03 This roll includes 3 revisions [1] and is purely to make sure those revisions didn't break anything. [1] https://chromium.googlesource.com/chromium/buildtools/+log/31d4daa..b53a03 BUG=593874 ========== to ========== Roll buildtools to b53a03 This roll includes 3 revisions [1] and is purely to make sure those revisions didn't break anything. [1] https://chromium.googlesource.com/chromium/buildtools/+log/31d4daa..b53a03 BUG=593874 R=thestig@chromium.org ==========
Description was changed from ========== Roll buildtools to b53a03 This roll includes 3 revisions [1] and is purely to make sure those revisions didn't break anything. [1] https://chromium.googlesource.com/chromium/buildtools/+log/31d4daa..b53a03 BUG=593874 R=thestig@chromium.org ========== to ========== Roll buildtools to b53a03 This roll includes 3 revisions [1] and is purely to make sure those revisions didn't break anything. [1] https://chromium.googlesource.com/chromium/buildtools/+log/31d4daa..b53a03 BUG=593874 R=thestig@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng ==========
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
thomasanderson@chromium.org changed reviewers: + thestig@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
stampy lgtm Why not ask hans?
On 2017/06/09 01:04:58, Lei Zhang wrote: > stampy lgtm > > Why not ask hans? well.. normally I would ask thakis@ but he's OOO, and I saw that he added you on one of the buildtools rolls (but I guess anyone can review DEPS changes)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_ubsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thomasanderson@chromium.org
Description was changed from ========== Roll buildtools to b53a03 This roll includes 3 revisions [1] and is purely to make sure those revisions didn't break anything. [1] https://chromium.googlesource.com/chromium/buildtools/+log/31d4daa..b53a03 BUG=593874 R=thestig@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng ========== to ========== Roll buildtools to b53a03 This roll includes 3 revisions [1] and is purely to make sure those revisions didn't break anything. [1] https://chromium.googlesource.com/chromium/buildtools/+log/31d4daa..b53a03 BUG=593874 R=thestig@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng ==========
The CQ bit was checked by thomasanderson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
linux_chromium_ubsan_rel_ng is broken right now, so landing without it
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1496983938404070, "parent_rev": "1ac9902a04fadaa7e3f307cee39659578e53fe18", "commit_rev": "e89683d4ca3cc61fed5984c234bab3f1dc6c3ef0"}
Message was sent while issue was closed.
Description was changed from ========== Roll buildtools to b53a03 This roll includes 3 revisions [1] and is purely to make sure those revisions didn't break anything. [1] https://chromium.googlesource.com/chromium/buildtools/+log/31d4daa..b53a03 BUG=593874 R=thestig@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng ========== to ========== Roll buildtools to b53a03 This roll includes 3 revisions [1] and is purely to make sure those revisions didn't break anything. [1] https://chromium.googlesource.com/chromium/buildtools/+log/31d4daa..b53a03 BUG=593874 R=thestig@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng Review-Url: https://codereview.chromium.org/2932783002 Cr-Commit-Position: refs/heads/master@{#478204} Committed: https://chromium.googlesource.com/chromium/src/+/e89683d4ca3cc61fed5984c234ba... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e89683d4ca3cc61fed5984c234ba... |