Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2932743002:
Closure compilation: Remove compile_js2.py error filtering. (Closed)
DescriptionClosure compilation: Remove compile_js2.py error filtering.
Errors related to Promises have been addressed by
https://github.com/google/closure-compiler/issues/715.
The other type of errors
"Variable x first declared in ..."
does not seem to happen anymore.
BUG=730866
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2932743002
Cr-Commit-Position: refs/heads/master@{#478069}
Committed: https://chromium.googlesource.com/chromium/src/+/e463990741a71d61a48cfe3dce6769b9d97c5164
Patch Set 1 #Patch Set 2 : Delete more #
Messages
Total messages: 21 (15 generated)
Description was changed from ========== DO NOT SUBMIT: Remove compile_js2.py error filtering, to see what breaks. BUG= ========== to ========== DO NOT SUBMIT: Remove compile_js2.py error filtering, to see what breaks. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== DO NOT SUBMIT: Remove compile_js2.py error filtering, to see what breaks. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Remove compile_js2.py error filtering. Errors related to Promises have been addressed BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Remove compile_js2.py error filtering. Errors related to Promises have been addressed BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Closure compilation: Remove compile_js2.py error filtering. Errors related to Promises have been addressed by https://github.com/google/closure-compiler/issues/715. The other type of errors "Variable x first declared in ..." does not seem to happen anymore. BUG=730866 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dpapad@chromium.org changed reviewers: + dbeam@chromium.org
@tbreisacher: Are you aware of any change in the Compiler itself, which could have addressed the "Variable x first defined ..." class of errors? It appears that these errors affected Chrome at some point, but I could not reproduce anymore (at least not locally and on tryjobs).
On 2017/06/08 19:26:47, dpapad wrote: > @tbreisacher: Are you aware of any change in the Compiler itself, which could > have addressed the "Variable x first defined ..." class of errors? It appears > that these errors affected Chrome at some point, but I could not reproduce > anymore (at least not locally and on tryjobs). Nothing comes to mind right away. Nice to see the chrome infra surrounding the compiler get simpler! \o/
On 2017/06/08 19:26:47, dpapad wrote: > @tbreisacher: Are you aware of any change in the Compiler itself, which could > have addressed the "Variable x first defined ..." class of errors? It appears > that these errors affected Chrome at some point, but I could not reproduce > anymore (at least not locally and on tryjobs). Nothing comes to mind right away. Nice to see the chrome infra surrounding the compiler get simpler! \o/
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
i think places like remoting/ that care about duplicates (but are no longer typechecked in this system) might've been what this code was addressing. either way, lgtm
The CQ bit was checked by dpapad@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496953237131460,
"parent_rev": "dfb76f24c05c31ce433a30fc9b774b25c01c89da", "commit_rev":
"e463990741a71d61a48cfe3dce6769b9d97c5164"}
Message was sent while issue was closed.
Description was changed from ========== Closure compilation: Remove compile_js2.py error filtering. Errors related to Promises have been addressed by https://github.com/google/closure-compiler/issues/715. The other type of errors "Variable x first declared in ..." does not seem to happen anymore. BUG=730866 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Closure compilation: Remove compile_js2.py error filtering. Errors related to Promises have been addressed by https://github.com/google/closure-compiler/issues/715. The other type of errors "Variable x first declared in ..." does not seem to happen anymore. BUG=730866 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2932743002 Cr-Commit-Position: refs/heads/master@{#478069} Committed: https://chromium.googlesource.com/chromium/src/+/e463990741a71d61a48cfe3dce67... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/e463990741a71d61a48cfe3dce67... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
