Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2932733002: config_service: optimize projects.get_metadata (Closed)

Created:
3 years, 6 months ago by nodir
Modified:
3 years, 6 months ago
Reviewers:
Sergey Berezin, hinoka
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: optimize projects.get_metadata projects.get_metadata is used for all ACL checks for project config sets, thus it must be fast. Also it never changes. Cache it for 10m R=hinoka@chromium.org, sergeyberezin@chromium.org BUG=730832 Review-Url: https://codereview.chromium.org/2932733002 Committed: https://github.com/luci/luci-py/commit/bb34bc085032b88295f0215050c8735ea554b40b

Patch Set 1 #

Patch Set 2 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M appengine/config_service/projects.py View 1 2 chunks +33 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nodir
PTAL
3 years, 6 months ago (2017-06-08 17:26:17 UTC) #1
Sergey Berezin
lgtm
3 years, 6 months ago (2017-06-08 18:04:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932733002/20001
3 years, 6 months ago (2017-06-08 18:09:40 UTC) #4
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 18:11:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/bb34bc085032b88295f0215050c8735ea554b40b

Powered by Google App Engine
This is Rietveld 408576698