Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2932703004: [Payment Request] Contact Info editor (Closed)

Created:
3 years, 6 months ago by Moe
Modified:
3 years, 6 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] Contact Info editor Creates a coordinator and a mediator in order to display and populate the Payment Request edit view controller when creating/editing a contact info profile. http://imgur.com/a/FB9S3 BUG=602666 Review-Url: https://codereview.chromium.org/2932703004 Cr-Commit-Position: refs/heads/master@{#478302} Committed: https://chromium.googlesource.com/chromium/src/+/463a1f91cd5e9f96995d21727244df88c70820bd

Patch Set 1 : Initial #

Total comments: 4

Patch Set 2 : Addressed comments #

Messages

Total messages: 23 (18 generated)
Moe
Hi Louis, Please take a look.
3 years, 6 months ago (2017-06-08 17:59:47 UTC) #2
lpromero
lgtm https://codereview.chromium.org/2932703004/diff/40001/ios/chrome/browser/ui/payments/contact_info_edit_coordinator_unittest.mm File ios/chrome/browser/ui/payments/contact_info_edit_coordinator_unittest.mm (right): https://codereview.chromium.org/2932703004/diff/40001/ios/chrome/browser/ui/payments/contact_info_edit_coordinator_unittest.mm#newcode202 ios/chrome/browser/ui/payments/contact_info_edit_coordinator_unittest.mm:202: // user has finished editing a profile, causes ...
3 years, 6 months ago (2017-06-09 10:37:12 UTC) #12
Moe
Thank you Louis! https://codereview.chromium.org/2932703004/diff/40001/ios/chrome/browser/ui/payments/contact_info_edit_coordinator_unittest.mm File ios/chrome/browser/ui/payments/contact_info_edit_coordinator_unittest.mm (right): https://codereview.chromium.org/2932703004/diff/40001/ios/chrome/browser/ui/payments/contact_info_edit_coordinator_unittest.mm#newcode202 ios/chrome/browser/ui/payments/contact_info_edit_coordinator_unittest.mm:202: // user has finished editing a ...
3 years, 6 months ago (2017-06-09 15:01:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932703004/60001
3 years, 6 months ago (2017-06-09 16:33:50 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 16:39:39 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/463a1f91cd5e9f96995d21727244...

Powered by Google App Engine
This is Rietveld 408576698