Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1354)

Unified Diff: android_webview/common/aw_paths.cc

Issue 2932703003: Plumbing for safe browsing reporting for Android WebView. (Closed)
Patch Set: address comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/common/aw_paths.cc
diff --git a/android_webview/common/aw_paths.cc b/android_webview/common/aw_paths.cc
index 2e57b0042d840589d88153694ad0d58378e4b848..390a7bed8d1e4fa241af20ceb9bcc1feb0c72483 100644
--- a/android_webview/common/aw_paths.cc
+++ b/android_webview/common/aw_paths.cc
@@ -21,6 +21,12 @@ bool PathProvider(int key, base::FilePath* result) {
cur = cur.Append(FILE_PATH_LITERAL("WebView"))
.Append(FILE_PATH_LITERAL("Crash Reports"));
break;
+ case DIR_SAFE_BROWSING:
+ if (!base::android::GetCacheDirectory(&cur))
+ return false;
+ cur = cur.Append(FILE_PATH_LITERAL("WebView"))
+ .Append(FILE_PATH_LITERAL("SafeBrowsing"));
Tobias Sargeant 2017/06/09 14:57:02 is that directory going to get created by existing
timvolodine 2017/06/09 16:28:43 Good point thanks for noticing! I guess I'll need
timvolodine 2017/06/09 17:48:48 After the meeting today, went with DIR_SAFE_BROWSI
+ break;
default:
return false;
}

Powered by Google App Engine
This is Rietveld 408576698