Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: android_webview/browser/aw_safe_browsing_blocking_page.cc

Issue 2932703003: Plumbing for safe browsing reporting for Android WebView. (Closed)
Patch Set: address comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_safe_browsing_blocking_page.cc
diff --git a/android_webview/browser/aw_safe_browsing_blocking_page.cc b/android_webview/browser/aw_safe_browsing_blocking_page.cc
index 7f505a3a9c0ef926452c29044e2e561414d9f332..602c24b5864cfc4facabae06555aac2c98792a9c 100644
--- a/android_webview/browser/aw_safe_browsing_blocking_page.cc
+++ b/android_webview/browser/aw_safe_browsing_blocking_page.cc
@@ -43,6 +43,8 @@ AwSafeBrowsingBlockingPage::AwSafeBrowsingBlockingPage(
ui_manager->app_locale(), base::Time::NowFromSystemTime(), controller(),
errorUiType == ErrorUiType::QUIET_GIANT));
}
+ // TODO(timvolodine): add call to
+ // TriggerManager::StartCollectingThreatDetails().
lpz 2017/06/09 14:54:50 note also that after https://chromium-review.googl
timvolodine 2017/06/09 16:28:43 Ah thanks for pointing out, filed crbug.com/731747
}
// static

Powered by Google App Engine
This is Rietveld 408576698