Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2932643003: Move InSameBlock() to InsertParagraphSeparatorCommand.cpp (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move InSameBlock() to InsertParagraphSeparatorCommand.cpp This patch moves |InSameBlock()| to "InsertParagraphSeparatorCommand.cpp" since it is used only in there for improving code health. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2932643003 Cr-Commit-Position: refs/heads/master@{#478150} Committed: https://chromium.googlesource.com/chromium/src/+/4c5f755739fcbe4021d3a2938571d066a1b2d5cf

Patch Set 1 : 2017-06-08T17:36:13 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-08 08:55:45 UTC) #5
Xiaocheng
lgtm
3 years, 6 months ago (2017-06-08 20:29:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932643003/1
3 years, 6 months ago (2017-06-09 01:05:19 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 01:11:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4c5f755739fcbe4021d3a2938571...

Powered by Google App Engine
This is Rietveld 408576698