Simplify WebAPK proto building code

Simplify WebAPK proto building code

This CL:
- Consolidates the WebAPK proto building in BuildProtoInBackground().
- Adds a BuildProto() method and makes callers use it instead of calling
  BuildWebApkProtoInBackground() directly.

BUG=713655
Review-Url: https://codereview.chromium.org/2932593005
Cr-Commit-Position: refs/heads/master@{#479199}
Committed: https://chromium.googlesource.com/chromium/src/+/1da39ba92b277ea834d61e6fb00d32177a472ebd

[pkotwicz, 2017-06-09 03:21:19]

Patchset #3 (id:40001) has been deleted

[pkotwicz, 2017-06-09 03:21:24]

Patchset #2 (id:20001) has been deleted

[pkotwicz, 2017-06-09 03:21:29]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2017-06-09 03:21:45]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2017-06-09 03:21:46]

Xi, can you please take a look?

[Xi Han, 2017-06-09 14:15:10]

lgtm with nits.

https://codereview.chromium.org/2932593005/diff/60001/chrome/browser/android/...
File chrome/browser/android/webapk/webapk_installer.h (right):

https://codereview.chromium.org/2932593005/diff/60001/chrome/browser/android/...
chrome/browser/android/webapk/webapk_installer.h:90: // Builds proto for install
or update request.
How about "Builds proto in the background for install or update request."?

It is worthy mentioning that this function actually post task to the background
to complete the task.

[pkotwicz, 2017-06-12 03:47:41]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2017-06-12 03:47:42]

Dominick for OWNERS

https://codereview.chromium.org/2932593005/diff/60001/chrome/browser/android/...
File chrome/browser/android/webapk/webapk_installer.h (right):

https://codereview.chromium.org/2932593005/diff/60001/chrome/browser/android/...
chrome/browser/android/webapk/webapk_installer.h:90: // Builds proto for install
or update request.
On 2017/06/09 14:15:10, Xi Han wrote:
> How about "Builds proto in the background for install or update request."?
> 
> It is worthy mentioning that this function actually post task to the
background
> to complete the task.

Done.

[dominickn, 2017-06-13 00:12:57]

lgtm % minor comment nit

https://codereview.chromium.org/2932593005/diff/80001/chrome/browser/android/...
File chrome/browser/android/webapk/webapk_installer.h (right):

https://codereview.chromium.org/2932593005/diff/80001/chrome/browser/android/...
chrome/browser/android/webapk/webapk_installer.h:90: // Builds proto in the
background for install or update request.
Minor comment clarification:

"Asynchronously builds the WebAPK proto on a background thread for an update or
install request. Runs |callback| on the calling thread when complete."

[pkotwicz, 2017-06-13 16:57:57]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2017-06-13 16:57:59]

The patchset sent to the CQ was uploaded after l-g-t-m from hanxi@chromium.org,
dominickn@chromium.org
Link to the patchset: https://codereview.chromium.org/2932593005/#ps100001
(title: "Merge branch 'master' into background_updates000")

[commit-bot: I haz the power, 2017-06-13 16:58:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 17:00:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 17:00:06]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pkotwicz, 2017-06-13 19:07:26]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2017-06-13 19:08:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 19:11:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 19:11:59]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[pkotwicz, 2017-06-13 22:26:46]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2017-06-13 22:26:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org, hanxi@chromium.org
Link to the patchset: https://codereview.chromium.org/2932593005/#ps120001
(title: "Merge branch 'master' into background_updates000")

[commit-bot: I haz the power, 2017-06-13 22:27:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 23:16:54]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1497392806200180,
"parent_rev": "1b569dc2c54a3bbded604ec0c1310e3daf43c3a3", "commit_rev":
"1da39ba92b277ea834d61e6fb00d32177a472ebd"}

[commit-bot: I haz the power, 2017-06-13 23:17:11]

Description was changed from

==========
Simplify WebAPK proto building code

This CL:
- Consolidates the WebAPK proto building in BuildProtoInBackground().
- Adds a BuildProto() method and makes callers use it instead of calling
  BuildWebApkProtoInBackground() directly.

BUG=713655
==========

to

==========
Simplify WebAPK proto building code

This CL:
- Consolidates the WebAPK proto building in BuildProtoInBackground().
- Adds a BuildProto() method and makes callers use it instead of calling
  BuildWebApkProtoInBackground() directly.

BUG=713655

Review-Url: https://codereview.chromium.org/2932593005
Cr-Commit-Position: refs/heads/master@{#479199}
Committed:
https://chromium.googlesource.com/chromium/src/+/1da39ba92b277ea834d61e6fb00d...
==========

[commit-bot: I haz the power, 2017-06-13 23:17:13]

Committed patchset #4 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/1da39ba92b277ea834d61e6fb00d...