Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2932573002: [VrShell] Fix incorrect loading indicator colors. (Closed)

Created:
3 years, 6 months ago by amp
Modified:
3 years, 6 months ago
Reviewers:
cjgrant
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[VrShell] Fix incorrect loading indicator colors. This also reorganizes the names to always have foreground first. Change-Id: Iad914ead69489069f5f07d6d7cf6ef7adae17053 Reviewed-on: https://chromium-review.googlesource.com/527533 Reviewed-by: Christopher Grant <cjgrant@chromium.org>; Commit-Queue: Christopher Grant <cjgrant@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#477750} Review-Url: https://codereview.chromium.org/2932573002 Cr-Commit-Position: refs/branch-heads/3112@{#245} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/3b7fa075a1b778e4763b6edc3085a14dc5ad5508

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M chrome/browser/android/vr_shell/color_scheme.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/android/vr_shell/color_scheme.cc View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
amp
drover merge to 60, need committer lgtm. Note that the exit prompt will not be ...
3 years, 6 months ago (2017-06-07 23:28:20 UTC) #3
cjgrant
lgtm
3 years, 6 months ago (2017-06-08 01:24:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932573002/1
3 years, 6 months ago (2017-06-08 01:31:18 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 01:31:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3b7fa075a1b778e4763b6edc3085...

Powered by Google App Engine
This is Rietveld 408576698