Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2932553003: Enable spec-compliant canplaythrough event by default (Closed)

Created:
3 years, 6 months ago by hubbe
Modified:
3 years, 6 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable spec-compliant canplaythrough event by default The results from this study are in. As expected, Media.Video.Autoplay.Attribute.WaitTime goes up, by up to 10%. In return we get a bigger than expected positive impact on Media.UnderflowDuration and Media.MeanTimeBetweenRebuffers.AudioVideo.SRC. Going to default this feature to ON, but leave the flag in place for one release in case we need to revert it for any reason. BUG=725576, 73609 Review-Url: https://codereview.chromium.org/2932553003 Cr-Commit-Position: refs/heads/master@{#478093} Committed: https://chromium.googlesource.com/chromium/src/+/e3338722a11a1b0cac7b4a189532bbf52b34193c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/base/media_switches.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
hubbe
3 years, 6 months ago (2017-06-08 19:28:55 UTC) #4
DaleCurtis
lgtm % summarizing the improvements seen in the commit message.
3 years, 6 months ago (2017-06-08 19:30:53 UTC) #5
DaleCurtis
Also we should delete that kUseNewMediaCache in a followup CL :)
3 years, 6 months ago (2017-06-08 19:31:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932553003/1
3 years, 6 months ago (2017-06-08 19:34:41 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 21:32:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e3338722a11a1b0cac7b4a189532...

Powered by Google App Engine
This is Rietveld 408576698