Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 293253003: Revert 272540 "Revert 272504 "Destroy all rtc peer connection ha..." (Closed)

Created:
6 years, 7 months ago by fgorski
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 272540 "Revert 272504 "Destroy all rtc peer connection ha..." The original change was not a root cause of the problem. sheriffs are looking into other possible causes. Meanwhile I am getting the change back in. > Revert 272504 "Destroy all rtc peer connection handlers before s..." > > On Win7 Tests (dbg)(2) these tests > > FocusElementCallsFocusedNodeChanged > GetCompositionCharacterBoundsTest > MessageOrderInDidChangeSelection > OnExtendSelectionAndDelete > OnImeTypeChanged > OnSetTextDirection > SendCandidateWindowEvents > SetEditableSelectionAndComposition > > fail with timeout. > http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%282%29/builds/21101/steps/content_browsertests/logs/stdio > > > Destroy all rtc peer connection handlers before shutting down blink > > > > The connection handlers will otherwise continue to call into blink which > > is bound to crash after it was shut down. > > > > BUG=337572 > > R=perkj@chromium.org,adamk@chromium.org > > > > Review URL: https://codereview.chromium.org/292163002 > > TBR=jochen@chromium.org > > Review URL: https://codereview.chromium.org/296213007 TBR=vasilii@chromium.org,jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M trunk/src/content/renderer/media/rtc_peer_connection_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/media/rtc_peer_connection_handler.cc View 5 chunks +22 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/render_thread_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fgorski
6 years, 7 months ago (2014-05-23 22:00:00 UTC) #1
fgorski
Committed patchset #1 manually as r272604.
6 years, 7 months ago (2014-05-23 22:00:10 UTC) #2
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-24 10:17:20 UTC) #3
Message was sent while issue was closed.
thx for relanding

Powered by Google App Engine
This is Rietveld 408576698