Issue 296213007: Revert 272504 "Destroy all rtc peer connection handlers before s..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296213007: Revert 272504 "Destroy all rtc peer connection handlers before s..." (Closed)

Created:
6 years, 7 months ago by vasilii

Modified:
6 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 272504 "Destroy all rtc peer connection handlers before s..." On Win7 Tests (dbg)(2) these tests FocusElementCallsFocusedNodeChanged GetCompositionCharacterBoundsTest MessageOrderInDidChangeSelection OnExtendSelectionAndDelete OnImeTypeChanged OnSetTextDirection SendCandidateWindowEvents SetEditableSelectionAndComposition fail with timeout. http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%282%29/builds/21101/steps/content_browsertests/logs/stdio > Destroy all rtc peer connection handlers before shutting down blink > > The connection handlers will otherwise continue to call into blink which > is bound to crash after it was shut down. > > BUG=337572 > R=perkj@chromium.org,adamk@chromium.org > > Review URL: https://codereview.chromium.org/292163002 TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272540

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -28 lines)			Patch
M	trunk/src/content/renderer/media/rtc_peer_connection_handler.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/content/renderer/media/rtc_peer_connection_handler.cc	View	5 chunks	+0 lines, -22 lines	0 comments	Download
M	trunk/src/content/renderer/render_thread_impl.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

vasilii

6 years, 7 months ago (2014-05-23 15:51:34 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r272540 (tree was closed).