Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2932503005: Change AlternativeServiceInfo to a class (Closed)

Created:
3 years, 6 months ago by Zhongyi Shi
Modified:
3 years, 6 months ago
Reviewers:
Bence
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change AlternativeServiceInfo to a class This is in preparation for adding a private field: advertised_versions to AlternativeServiceInfo. BUG=689762 Review-Url: https://codereview.chromium.org/2932503005 Cr-Commit-Position: refs/heads/master@{#478453} Committed: https://chromium.googlesource.com/chromium/src/+/422ce3567ed22a4611f0ab5caccbc0cf123040df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -144 lines) Patch
M net/http/bidirectional_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_server_properties.h View 2 chunks +34 lines, -13 lines 0 comments Download
M net/http/http_server_properties.cc View 2 chunks +21 lines, -2 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 18 chunks +32 lines, -32 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 7 chunks +15 lines, -15 lines 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 7 chunks +43 lines, -40 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 6 chunks +16 lines, -14 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_network_transaction_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M net/spdy/chromium/spdy_session_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Zhongyi Shi
bnc@: PTAL, thanks! This is originated from https://codereview.chromium.org/2901093004/, where we added a new field to ...
3 years, 6 months ago (2017-06-09 06:44:29 UTC) #4
Bence
LGTM. Thank you for taking the extra effort to factor this change out, https://crrev.com/2901093004 will ...
3 years, 6 months ago (2017-06-09 18:01:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932503005/1
3 years, 6 months ago (2017-06-09 22:59:02 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 23:29:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/422ce3567ed22a4611f0ab5caccb...

Powered by Google App Engine
This is Rietveld 408576698