VR: Update back button state in more places.

VR: Update back button state in more places.

I looked at all of the spots clank updates back button enabled-ness, and
added all of the ones that looked relevant to VrShell.

BUG=728435
Review-Url: https://codereview.chromium.org/2932493002
Cr-Commit-Position: refs/heads/master@{#477982}
Committed: https://chromium.googlesource.com/chromium/src/+/529e5a534ca028c743dcbd3d284657c981a8b776

[mthiesse, 2017-06-07 18:22:26]

Description was changed from

==========
VR: Update back button state in more places.

I looked at all of the spots clank updates back button visibility, and
added all of the ones that looked relevant to VrShell.

BUG=728435
==========

to

==========
VR: Update back button state in more places.

I looked at all of the spots clank updates back button enabled-ness, and
added all of the ones that looked relevant to VrShell.

BUG=728435
==========

[mthiesse, 2017-06-07 18:22:40]

mthiesse@chromium.org changed reviewers:
+ bshe@chromium.org

[mthiesse, 2017-06-07 18:22:41]

PTAL.

[mthiesse, 2017-06-07 18:27:56]

I've filed crbug.com/730707 for testing. This CL is kept small to avoid issues
merging back to M60.

[bshe, 2017-06-08 15:04:19]

Just a small nit. It wont cause problem since you have equality check in the
update function. IIUC, we want to keep our behavior similar to the logic in
ToolbarManager.java, right?

https://codereview.chromium.org/2932493002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
(right):

https://codereview.chromium.org/2932493002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java:235:
updateHistoryButtonsVisibility();
Is this needed? In ToolbarManager.java, it doesnt seem to update navigation
button visibility when load stopped.

[mthiesse, 2017-06-08 15:07:44]

https://codereview.chromium.org/2932493002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
(right):

https://codereview.chromium.org/2932493002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java:235:
updateHistoryButtonsVisibility();
On 2017/06/08 15:04:19, bshe(OOO) wrote:
> Is this needed? In ToolbarManager.java, it doesnt seem to update navigation
> button visibility when load stopped.

In ToolbarManager.java it calls updateTabLoadingState(true), which calls
updateButtonStatus(), so it does update button visibility.

[bshe, 2017-06-08 15:13:14]

On 2017/06/08 15:07:44, mthiesse wrote:
>
https://codereview.chromium.org/2932493002/diff/1/chrome/android/java/src/org...
> File
> chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
> (right):
> 
>
https://codereview.chromium.org/2932493002/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java:235:
> updateHistoryButtonsVisibility();
> On 2017/06/08 15:04:19, bshe(OOO) wrote:
> > Is this needed? In ToolbarManager.java, it doesnt seem to update navigation
> > button visibility when load stopped.
> 
> In ToolbarManager.java it calls updateTabLoadingState(true), which calls
> updateButtonStatus(), so it does update button visibility.

lgtm

[mthiesse, 2017-06-08 15:14:59]

The CQ bit was checked by mthiesse@chromium.org

[commit-bot: I haz the power, 2017-06-08 15:15:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 16:02:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496934899813860, "parent_rev":
"d6cd6ca264c9e4071c32d9c09d8a80cf4b828063", "commit_rev":
"529e5a534ca028c743dcbd3d284657c981a8b776"}

[commit-bot: I haz the power, 2017-06-08 16:03:03]

Description was changed from

==========
VR: Update back button state in more places.

I looked at all of the spots clank updates back button enabled-ness, and
added all of the ones that looked relevant to VrShell.

BUG=728435
==========

to

==========
VR: Update back button state in more places.

I looked at all of the spots clank updates back button enabled-ness, and
added all of the ones that looked relevant to VrShell.

BUG=728435

Review-Url: https://codereview.chromium.org/2932493002
Cr-Commit-Position: refs/heads/master@{#477982}
Committed:
https://chromium.googlesource.com/chromium/src/+/529e5a534ca028c743dcbd3d2846...
==========

[commit-bot: I haz the power, 2017-06-08 16:03:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/529e5a534ca028c743dcbd3d2846...