Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2932473004: Remove depprecated methods in AppleKeychain. (Closed)

Created:
3 years, 6 months ago by vasilii
Modified:
3 years, 6 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove depprecated methods in AppleKeychain. BUG=595468 Review-Url: https://codereview.chromium.org/2932473004 Cr-Commit-Position: refs/heads/master@{#478050} Committed: https://chromium.googlesource.com/chromium/src/+/5baf4fded76e4e9a6890e09081d9d77c464cfe82

Patch Set 1 #

Patch Set 2 : Clean up everything #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -800 lines) Patch
M crypto/apple_keychain.h View 1 1 chunk +0 lines, -43 lines 0 comments Download
M crypto/apple_keychain_mac.mm View 1 2 chunks +0 lines, -87 lines 0 comments Download
M crypto/mock_apple_keychain.h View 1 4 chunks +2 lines, -168 lines 0 comments Download
M crypto/mock_apple_keychain.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M crypto/mock_apple_keychain_mac.cc View 1 1 chunk +2 lines, -499 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
vasilii
Hi Ryan, please review
3 years, 6 months ago (2017-06-08 14:40:02 UTC) #4
Ryan Sleevi
Since these aren't used, LGTM Are there other methods we can remove?
3 years, 6 months ago (2017-06-08 15:51:36 UTC) #7
vasilii
On 2017/06/08 15:51:36, Ryan Sleevi wrote: > Since these aren't used, LGTM > > Are ...
3 years, 6 months ago (2017-06-08 17:54:11 UTC) #10
Ryan Sleevi
lgtm
3 years, 6 months ago (2017-06-08 18:00:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932473004/20001
3 years, 6 months ago (2017-06-08 19:17:38 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 19:22:53 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5baf4fded76e4e9a6890e09081d9...

Powered by Google App Engine
This is Rietveld 408576698