Initial transfer.

Update Probe to be a general-purpose library.

Copy "probe" from "infra":
https://chromium.googlesource.com/infra/infra/+/444e6a3f1c2cac2a8b1232aa1321c2f4cc1ae2b0/go/src/infra/tools/git

Generalize it so that it can be used by other wrappers (notably
"vpython").

BUG=chromium:730649
TEST=unit

Review-Url: https://codereview.chromium.org/2932443002
Committed: https://github.com/luci/luci-go/commit/85885811d2157568a42bb39001ab39345724555c

[dnj, 2017-06-07 16:06:49]

dnj@chromium.org changed reviewers:
+ dnj@chromium.org, iannucci@chromium.org, nodir@chromium.org

[dnj, 2017-06-07 16:06:49]

PTAL. PS1 is the original Git wrapper code, so you can diff to see the
differences!

[dnj (Google), 2017-06-07 16:28:33]

another log

[dnj (Google), 2017-06-07 16:29:23]

fix error

[dnj, 2017-06-07 16:45:34]

Description was changed from

==========
Initial transfer.
==========

to

==========
Update Probe to be a general-purpose library.

Copy "probe" from "infra":
https://chromium.googlesource.com/infra/infra/+/444e6a3f1c2cac2a8b1232aa1321c...

Generalize it so that it can be used by other wrappers (notably
"vpython").

BUG=chromium:730649
TEST=unit
==========

[iannucci, 2017-06-07 17:01:12]

lgtm

https://codereview.chromium.org/2932443002/diff/60001/common/wrapper/prober/p...
File common/wrapper/prober/probe.go (right):

https://codereview.chromium.org/2932443002/diff/60001/common/wrapper/prober/p...
common/wrapper/prober/probe.go:31: // Target should be an executable name
resolvable by exec.LookPath. On both
"both" windows systems?

https://codereview.chromium.org/2932443002/diff/60001/common/wrapper/prober/p...
common/wrapper/prober/probe.go:68: // SelfStat is the FileInfo for self. If self
is not empty, SelfStat will not
newline.

If you want to group these, I would do

// Self and SelfStat are set via ResolveSelf. If they're empty, it means that
the executable hasn't been resolved yet
//
// More details about Self
// More details about SelfStat
Self string
SelfStat os.FileInfo

[dnj (Google), 2017-06-07 17:08:23]

comment

[dnj, 2017-06-07 17:09:13]

https://codereview.chromium.org/2932443002/diff/60001/common/wrapper/prober/p...
File common/wrapper/prober/probe.go (right):

https://codereview.chromium.org/2932443002/diff/60001/common/wrapper/prober/p...
common/wrapper/prober/probe.go:31: // Target should be an executable name
resolvable by exec.LookPath. On both
On 2017/06/07 17:01:12, iannucci wrote:
> "both" windows systems?

Done.

https://codereview.chromium.org/2932443002/diff/60001/common/wrapper/prober/p...
common/wrapper/prober/probe.go:68: // SelfStat is the FileInfo for self. If self
is not empty, SelfStat will not
On 2017/06/07 17:01:12, iannucci wrote:
> newline.
> 
> If you want to group these, I would do
> 
> // Self and SelfStat are set via ResolveSelf. If they're empty, it means that
> the executable hasn't been resolved yet
> //
> // More details about Self
> // More details about SelfStat
> Self string
> SelfStat os.FileInfo

Done.

[dnj (Google), 2017-06-07 17:09:35]

move to system

[dnj, 2017-06-07 17:09:37]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-06-07 17:09:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2932443002/#ps100001
(title: "move to system")

[commit-bot: I haz the power, 2017-06-07 17:10:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 17:15:48]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1496855377432980,
"parent_rev": "98bc6697c7d6ffb6dd445180d5cd0d8426aab28d", "commit_rev":
"85885811d2157568a42bb39001ab39345724555c"}

[commit-bot: I haz the power, 2017-06-07 17:15:51]

Description was changed from

==========
Update Probe to be a general-purpose library.

Copy "probe" from "infra":
https://chromium.googlesource.com/infra/infra/+/444e6a3f1c2cac2a8b1232aa1321c...

Generalize it so that it can be used by other wrappers (notably
"vpython").

BUG=chromium:730649
TEST=unit
==========

to

==========
Update Probe to be a general-purpose library.

Copy "probe" from "infra":
https://chromium.googlesource.com/infra/infra/+/444e6a3f1c2cac2a8b1232aa1321c...

Generalize it so that it can be used by other wrappers (notably
"vpython").

BUG=chromium:730649
TEST=unit

Review-Url: https://codereview.chromium.org/2932443002
Committed:
https://github.com/luci/luci-go/commit/85885811d2157568a42bb39001ab39345724555c
==========

[commit-bot: I haz the power, 2017-06-07 17:15:52]

Committed patchset #6 (id:100001) as
https://github.com/luci/luci-go/commit/85885811d2157568a42bb39001ab39345724555c