Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2932353002: [ObjC ARC] Converts components/dom_distiller/ios:ios to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts components/dom_distiller/ios:ios to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2932353002 Cr-Commit-Position: refs/heads/master@{#478973} Committed: https://chromium.googlesource.com/chromium/src/+/1239197f348a128f1da26c32feae319ddc4227ea

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change typecast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M components/dom_distiller/ios/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/ios/distiller_page_factory_ios.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M components/dom_distiller/ios/distiller_page_ios.mm View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-12 17:09:48 UTC) #6
noyau (Ping after 24h)
lgtm https://codereview.chromium.org/2932353002/diff/1/components/dom_distiller/ios/distiller_page_ios.mm File components/dom_distiller/ios/distiller_page_ios.mm (right): https://codereview.chromium.org/2932353002/diff/1/components/dom_distiller/ios/distiller_page_ios.mm#newcode55 components/dom_distiller/ios/distiller_page_ios.mm:55: CFTypeID result_type = CFGetTypeID(reinterpret_cast<const void*>(wk_result)); reinterpret_cast<CFTypeRef> maybe?
3 years, 6 months ago (2017-06-13 08:40:44 UTC) #7
marq (ping after 24h)
Change typecast
3 years, 6 months ago (2017-06-13 10:38:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932353002/20001
3 years, 6 months ago (2017-06-13 10:38:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/1239197f348a128f1da26c32feae319ddc4227ea
3 years, 6 months ago (2017-06-13 11:52:39 UTC) #15
marq (ping after 24h)
3 years, 6 months ago (2017-06-13 13:10:47 UTC) #16
Message was sent while issue was closed.
https://codereview.chromium.org/2932353002/diff/1/components/dom_distiller/io...
File components/dom_distiller/ios/distiller_page_ios.mm (right):

https://codereview.chromium.org/2932353002/diff/1/components/dom_distiller/io...
components/dom_distiller/ios/distiller_page_ios.mm:55: CFTypeID result_type =
CFGetTypeID(reinterpret_cast<const void*>(wk_result));
On 2017/06/13 08:40:44, noyau (Ping after 24h) wrote:
> reinterpret_cast<CFTypeRef> maybe? 

Good call, done.

Powered by Google App Engine
This is Rietveld 408576698