Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: WATCHLISTS

Issue 2932323004: [infra] Add watchlist for build files. Clean up WATCHLISTS a bit (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: WATCHLISTS
diff --git a/WATCHLISTS b/WATCHLISTS
index 6f963c665c36a295cf5cea4945c0ff60b5c3fe93..70ce221144a9bcf39d550b088f5af6cd10ea5719 100644
--- a/WATCHLISTS
+++ b/WATCHLISTS
@@ -7,15 +7,16 @@
{
'WATCHLIST_DEFINITIONS': {
- 'runtime': {
- 'filepath': '^runtime/',
- },
- 'observatory': {
- 'filepath': 'runtime/bin/vmservice/' \
- '|runtime/bin/vmservice*' \
- '|runtime/observatory/' \
- '|runtime/vm/service/' \
- '|runtime/vm/service*'
+ 'build': {
+ 'filepath': (
+ '.*gyp$|'
+ '.*gypi$|'
+ '.*gn$|'
+ '.*gni$|'
+ '^tools/.*py$|'
+ '^build/|'
+ '^tools/buildtools/'
+ )
},
'front_end': {
'filepath': '^pkg/front_end',
@@ -34,12 +35,25 @@
')$'
)
},
+ 'observatory': {
+ 'filepath': (
+ '^runtime/bin/vmservice/|'
+ '^runtime/bin/vmservice*|'
+ '^runtime/observatory/|'
+ '^runtime/vm/service/|'
+ '^runtime/vm/service*|'
+ )
+ },
+ 'runtime': {
+ 'filepath': '^runtime/',
+ },
},
'WATCHLISTS': {
- 'runtime': ['vm-dev@dartlang.org'],
- 'observatory': ['turnidge@google.com', 'rmacnak@google.com'],
- 'front_end': ['dart-fe-team+reviews@google.com'],
+ 'build': [ 'zra@google.com' ],
+ 'front_end': [ 'dart-fe-team+reviews@google.com' ],
'messages_review': [ 'dart-uxr+reviews@google.com' ],
+ 'observatory': [ 'turnidge@google.com', 'rmacnak@google.com' ],
+ 'runtime': [ 'vm-dev@dartlang.org' ],
},
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698