Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: WATCHLISTS

Issue 2932323004: [infra] Add watchlist for build files. Clean up WATCHLISTS a bit (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 # Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 # for details. All rights reserved. Use of this source code is governed by a 2 # for details. All rights reserved. Use of this source code is governed by a
3 # BSD-style license that can be found in the LICENSE file. 3 # BSD-style license that can be found in the LICENSE file.
4 4
5 # Watchlist Rules 5 # Watchlist Rules
6 # Refer: http://dev.chromium.org/developers/contributing-code/watchlists 6 # Refer: http://dev.chromium.org/developers/contributing-code/watchlists
7 7
8 { 8 {
9 'WATCHLIST_DEFINITIONS': { 9 'WATCHLIST_DEFINITIONS': {
10 'runtime': { 10 'build': {
11 'filepath': '^runtime/', 11 'filepath': (
12 }, 12 '.*gyp$|'
13 'observatory': { 13 '.*gypi$|'
14 'filepath': 'runtime/bin/vmservice/' \ 14 '.*gn$|'
15 '|runtime/bin/vmservice*' \ 15 '.*gni$|'
16 '|runtime/observatory/' \ 16 '^tools/.*py$|'
17 '|runtime/vm/service/' \ 17 '^build/|'
18 '|runtime/vm/service*' 18 '^tools/buildtools/'
19 )
19 }, 20 },
20 'front_end': { 21 'front_end': {
21 'filepath': '^pkg/front_end', 22 'filepath': '^pkg/front_end',
22 }, 23 },
23 'messages_review': { 24 'messages_review': {
24 'filepath': ( 25 'filepath': (
25 '^(' 26 '^('
26 'pkg/front_end/messages\\.yaml|' 27 'pkg/front_end/messages\\.yaml|'
27 'pkg/compiler/lib/src/diagnostics/messages\\.dart|' 28 'pkg/compiler/lib/src/diagnostics/messages\\.dart|'
28 'pkg/analyzer/lib/src/analysis_options/error/option_codes\\.dart|' 29 'pkg/analyzer/lib/src/analysis_options/error/option_codes\\.dart|'
29 'pkg/analyzer/lib/src/dart/error/hint_codes\\.dart|' 30 'pkg/analyzer/lib/src/dart/error/hint_codes\\.dart|'
30 'pkg/analyzer/lib/src/dart/error/lint_codes\\.dart|' 31 'pkg/analyzer/lib/src/dart/error/lint_codes\\.dart|'
31 'pkg/analyzer/lib/src/dart/error/todo_codes\\.dart|' 32 'pkg/analyzer/lib/src/dart/error/todo_codes\\.dart|'
32 'pkg/analyzer/lib/src/html/error/html_codes\\.dart|' 33 'pkg/analyzer/lib/src/html/error/html_codes\\.dart|'
33 'pkg/dart_messages/lib/shared_messages\\.dart' 34 'pkg/dart_messages/lib/shared_messages\\.dart'
34 ')$' 35 ')$'
35 ) 36 )
36 }, 37 },
38 'observatory': {
39 'filepath': (
40 '^runtime/bin/vmservice/|'
41 '^runtime/bin/vmservice*|'
42 '^runtime/observatory/|'
43 '^runtime/vm/service/|'
44 '^runtime/vm/service*|'
45 )
46 },
47 'runtime': {
48 'filepath': '^runtime/',
49 },
37 }, 50 },
38 51
39 'WATCHLISTS': { 52 'WATCHLISTS': {
40 'runtime': ['vm-dev@dartlang.org'], 53 'build': [ 'zra@google.com' ],
41 'observatory': ['turnidge@google.com', 'rmacnak@google.com'], 54 'front_end': [ 'dart-fe-team+reviews@google.com' ],
42 'front_end': ['dart-fe-team+reviews@google.com'],
43 'messages_review': [ 'dart-uxr+reviews@google.com' ], 55 'messages_review': [ 'dart-uxr+reviews@google.com' ],
56 'observatory': [ 'turnidge@google.com', 'rmacnak@google.com' ],
57 'runtime': [ 'vm-dev@dartlang.org' ],
44 }, 58 },
45 } 59 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698