Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2932293002: Early return if SelectionInDOMTree is None at LayoutSelection::CalcSelectionPaintRange. (Closed)

Created:
3 years, 6 months ago by yoichio
Modified:
3 years, 6 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Early return if SelectionInDOMTree is None at LayoutSelection::CalcSelectionPaintRange. It must be Null SelectionPaintRange w/o calculating VSinFlatTree. BUG=708453 Review-Url: https://codereview.chromium.org/2932293002 Cr-Commit-Position: refs/heads/master@{#478567} Committed: https://chromium.googlesource.com/chromium/src/+/6e09d97394910e35d76264416d4df48c0e477d2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/LayoutSelection.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
yoichio
3 years, 6 months ago (2017-06-12 07:20:36 UTC) #5
yosin_UTC9
lgtm
3 years, 6 months ago (2017-06-12 08:20:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932293002/1
3 years, 6 months ago (2017-06-12 08:20:22 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 08:52:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6e09d97394910e35d76264416d4d...

Powered by Google App Engine
This is Rietveld 408576698