Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: ios/chrome/test/BUILD.gn

Issue 2932273003: [ObjC ARC] Converts ios/chrome/test:test_support to ARC. (Closed)
Patch Set: Block cleanup no non-ARC. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/test/ios_chrome_scoped_testing_chrome_browser_provider.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/test/BUILD.gn
diff --git a/ios/chrome/test/BUILD.gn b/ios/chrome/test/BUILD.gn
index 44ac22f58b65a0857655a95b1f8b729e5dfdf1c6..ce9b77b8b0154072d04369905a86d72271b99130 100644
--- a/ios/chrome/test/BUILD.gn
+++ b/ios/chrome/test/BUILD.gn
@@ -17,10 +17,9 @@ group("all_tests") {
}
source_set("test_support") {
+ configs += [ "//build/config/compiler:enable_arc" ]
testonly = true
sources = [
- "block_cleanup_test.h",
- "block_cleanup_test.mm",
"ios_chrome_scoped_testing_chrome_browser_provider.h",
"ios_chrome_scoped_testing_chrome_browser_provider.mm",
"ios_chrome_scoped_testing_chrome_browser_state_manager.cc",
@@ -34,6 +33,10 @@ source_set("test_support") {
"testing_application_context.mm",
]
+ public_deps = [
+ ":block_cleanup_test",
+ ]
+
deps = [
"//base",
"//base/test:test_support",
@@ -57,6 +60,20 @@ source_set("test_support") {
]
}
+source_set("block_cleanup_test") {
+ # The files in this target depend on non-ARC memeory management.
rohitrao (ping after 24h) 2017/06/14 12:30:05 I wonder if we should add a disable_arc target, so
rohitrao (ping after 24h) 2017/06/14 12:30:05 Typo: memory.
marq (ping after 24h) 2017/06/14 13:31:23 Good idea, created a bug for that.
marq (ping after 24h) 2017/06/14 13:31:23 Done.
+ testonly = true
+ sources = [
+ "block_cleanup_test.h",
+ "block_cleanup_test.mm",
+ ]
+
+ deps = [
+ "//base",
+ "//testing/gtest",
+ ]
+}
+
source_set("run_all_unittests") {
testonly = true
sources = [
« no previous file with comments | « no previous file | ios/chrome/test/ios_chrome_scoped_testing_chrome_browser_provider.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698