ServiceWorker: use the id assigned to the provider host in unittests

ServiceWorker: use the id assigned to the provider host in unittests

In several tests, currently provider's id is assigned to a variable which is
initialized by some random value at the beginning of the test, the provider host
instance is created by using the id, and some other objects are also initialized
by the id. After browser-side SWProviderHost creation, it'll be problematic
because the id will be assigned internally. This patch is to fix the tests by
getting the id from ServiceWorkerProviderHost::provider_id() directly.

This is split off from https://crrev.com/2779763004/ .

BUG=629701, 676983, 668633
Review-Url: https://codereview.chromium.org/2932273002
Cr-Commit-Position: refs/heads/master@{#478560}
Committed: https://chromium.googlesource.com/chromium/src/+/387a6b29a641d6721774f860c25fe85c47f821c0

[shimazu, 2017-06-12 05:30:21]

The CQ bit was checked by shimazu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 05:30:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shimazu, 2017-06-12 05:31:41]

Description was changed from

==========
ServiceWorker: use the id assigned to the provider host in unittests

In several tests, currently provider's id is assigned to a variable which is
initialized by some random value at the beginning of the test, the provider host
instance is created by using the id, and some other objects are also initialized
by the id. After browser-side SWProviderHost creation, it'll be problematic
because the id will be assigned internally. This patch is to fix the tests by
getting the id from ServiceWorkerProviderHost::provider_id() directly.

BUG=629701, 676983, 668633
==========

to

==========
ServiceWorker: use the id assigned to the provider host in unittests

In several tests, currently provider's id is assigned to a variable which is
initialized by some random value at the beginning of the test, the provider host
instance is created by using the id, and some other objects are also initialized
by the id. After browser-side SWProviderHost creation, it'll be problematic
because the id will be assigned internally. This patch is to fix the tests by
getting the id from ServiceWorkerProviderHost::provider_id() directly.

This is split off from https://crrev.com/2779763004/ .

BUG=629701, 676983, 668633
==========

[shimazu, 2017-06-12 05:49:14]

shimazu@chromium.org changed reviewers:
+ falken@chromium.org

[shimazu, 2017-06-12 05:49:14]

ptal, thanks! :)

[falken, 2017-06-12 06:33:07]

https://codereview.chromium.org/2932273002/diff/1/content/browser/service_wor...
File
content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
(right):

https://codereview.chromium.org/2932273002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc:344:
helper_->mock_render_process_id(), provider_id, version_);
Just to be sure, when the browser-side provider host change lands, this
|provider_id| is not used?

[shimazu, 2017-06-12 06:40:55]

https://codereview.chromium.org/2932273002/diff/1/content/browser/service_wor...
File
content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
(right):

https://codereview.chromium.org/2932273002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc:344:
helper_->mock_render_process_id(), provider_id, version_);
On 2017/06/12 06:33:07, falken wrote:
> Just to be sure, when the browser-side provider host change lands, this
> |provider_id| is not used?

Yes, that's right.

[falken, 2017-06-12 06:42:53]

Ah ok. lgtm

[shimazu, 2017-06-12 06:51:27]

The CQ bit was checked by shimazu@chromium.org

[shimazu, 2017-06-12 06:51:29]

The CQ bit was unchecked by shimazu@chromium.org

[shimazu, 2017-06-12 06:51:38]

The CQ bit was checked by shimazu@chromium.org

[commit-bot: I haz the power, 2017-06-12 06:51:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 07:09:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497250298962630, "parent_rev":
"c3065567be38abfc0c0354a04e4c48e85f44f49c", "commit_rev":
"387a6b29a641d6721774f860c25fe85c47f821c0"}

[commit-bot: I haz the power, 2017-06-12 07:09:26]

Description was changed from

==========
ServiceWorker: use the id assigned to the provider host in unittests

In several tests, currently provider's id is assigned to a variable which is
initialized by some random value at the beginning of the test, the provider host
instance is created by using the id, and some other objects are also initialized
by the id. After browser-side SWProviderHost creation, it'll be problematic
because the id will be assigned internally. This patch is to fix the tests by
getting the id from ServiceWorkerProviderHost::provider_id() directly.

This is split off from https://crrev.com/2779763004/ .

BUG=629701, 676983, 668633
==========

to

==========
ServiceWorker: use the id assigned to the provider host in unittests

In several tests, currently provider's id is assigned to a variable which is
initialized by some random value at the beginning of the test, the provider host
instance is created by using the id, and some other objects are also initialized
by the id. After browser-side SWProviderHost creation, it'll be problematic
because the id will be assigned internally. This patch is to fix the tests by
getting the id from ServiceWorkerProviderHost::provider_id() directly.

This is split off from https://crrev.com/2779763004/ .

BUG=629701, 676983, 668633

Review-Url: https://codereview.chromium.org/2932273002
Cr-Commit-Position: refs/heads/master@{#478560}
Committed:
https://chromium.googlesource.com/chromium/src/+/387a6b29a641d6721774f860c25f...
==========

[commit-bot: I haz the power, 2017-06-12 07:09:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/387a6b29a641d6721774f860c25f...