[cleanup] Remove instanceof cache.

[cleanup] Remove instanceof cache.

The instanceof cache was initially introduced to speed up

  x instanceof y

where y is always the same constructor and x is always an object with
the same map. With the introduction of ES2015's @@hasInstance and the
Function.prototype[Symbol.hasInstance] handler (which calls into
OrdinaryHasInstance), this already became quite useless. It doesn't seem
to provide any real value (not sure it ever did for real), but it's
getting in the way of some useful refactorings (i.e. sharing logic
between OrdinaryHasInstance and Object.prototype.isPrototypeOf for
example).

So this CL completely removes the leftover bits of the instanceof cache,
including the GC and SetPrototype logic.

BUG=v8:6479, v8:6474
R=jgruber@chromium.org
TBR=ulan@chromium.org

Review-Url: https://codereview.chromium.org/2932263002
Cr-Commit-Position: refs/heads/master@{#45835}
Committed: https://chromium.googlesource.com/v8/v8/+/f850b32d5c5d0391bcc166f4747ab35be75b6952

[Benedikt Meurer, 2017-06-11 17:03:05]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-11 17:03:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-06-11 17:03:33]

Description was changed from

==========
[cleanup] Remove instanceof cache.

The instanceof cache was initially introduced to speed up

  x instanceof y

where y is always the same constructor and x is always an object with
the same map. With the introduction of ES2015's @@hasInstance and the
Function.prototype[Symbol.hasInstance] handler (which calls into
OrdinaryHasInstance), this already became quite useless. It doesn't seem
to provide any real value (not sure it ever did for real), but it's
getting in the way of some useful refactorings (i.e. sharing logic
between OrdinaryHasInstance and Object.prototype.isPrototypeOf for
example).

So this CL completely removes the leftover bits of the instanceof cache,
including the GC and SetPrototype logic.

BUG=v8:6479,v8:6474
R=jgruber@chromium.org
==========

to

==========
[cleanup] Remove instanceof cache.

The instanceof cache was initially introduced to speed up

  x instanceof y

where y is always the same constructor and x is always an object with
the same map. With the introduction of ES2015's @@hasInstance and the
Function.prototype[Symbol.hasInstance] handler (which calls into
OrdinaryHasInstance), this already became quite useless. It doesn't seem
to provide any real value (not sure it ever did for real), but it's
getting in the way of some useful refactorings (i.e. sharing logic
between OrdinaryHasInstance and Object.prototype.isPrototypeOf for
example).

So this CL completely removes the leftover bits of the instanceof cache,
including the GC and SetPrototype logic.

BUG=v8:6479,v8:6474
R=jgruber@chromium.org
TBR=ulan@chromium.org
==========

[Benedikt Meurer, 2017-06-11 17:04:31]

Hey Jakob,

A bit late for the cleanup friday, but something that I've wanted to do for
quite a while now (not even sure that the instanceof cache is still correct with
all the recent changes anyways...).
Please take a look.

Thanks,
Benedikt

[commit-bot: I haz the power, 2017-06-11 17:34:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-11 17:34:23]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-06-12 06:38:56]

lgtm, thanks

[Benedikt Meurer, 2017-06-12 06:40:12]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-06-12 06:40:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 06:42:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497249612362430, "parent_rev":
"d258efb679927aa00881c801dd7a3a59f53ecb9a", "commit_rev":
"f850b32d5c5d0391bcc166f4747ab35be75b6952"}

[commit-bot: I haz the power, 2017-06-12 06:42:16]

Description was changed from

==========
[cleanup] Remove instanceof cache.

The instanceof cache was initially introduced to speed up

  x instanceof y

where y is always the same constructor and x is always an object with
the same map. With the introduction of ES2015's @@hasInstance and the
Function.prototype[Symbol.hasInstance] handler (which calls into
OrdinaryHasInstance), this already became quite useless. It doesn't seem
to provide any real value (not sure it ever did for real), but it's
getting in the way of some useful refactorings (i.e. sharing logic
between OrdinaryHasInstance and Object.prototype.isPrototypeOf for
example).

So this CL completely removes the leftover bits of the instanceof cache,
including the GC and SetPrototype logic.

BUG=v8:6479,v8:6474
R=jgruber@chromium.org
TBR=ulan@chromium.org
==========

to

==========
[cleanup] Remove instanceof cache.

The instanceof cache was initially introduced to speed up

  x instanceof y

where y is always the same constructor and x is always an object with
the same map. With the introduction of ES2015's @@hasInstance and the
Function.prototype[Symbol.hasInstance] handler (which calls into
OrdinaryHasInstance), this already became quite useless. It doesn't seem
to provide any real value (not sure it ever did for real), but it's
getting in the way of some useful refactorings (i.e. sharing logic
between OrdinaryHasInstance and Object.prototype.isPrototypeOf for
example).

So this CL completely removes the leftover bits of the instanceof cache,
including the GC and SetPrototype logic.

BUG=v8:6479,v8:6474
R=jgruber@chromium.org
TBR=ulan@chromium.org

Review-Url: https://codereview.chromium.org/2932263002
Cr-Commit-Position: refs/heads/master@{#45835}
Committed:
https://chromium.googlesource.com/v8/v8/+/f850b32d5c5d0391bcc166f4747ab35be75...
==========

[commit-bot: I haz the power, 2017-06-12 06:42:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f850b32d5c5d0391bcc166f4747ab35be75...