Refactor ChooserDialogView to use borders instead of content margins.

chrome/browser/chooser_controller/chooser_controller.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHOOSER_CONTROLLER_CHOOSER_CONTROLLER_H_
 #define CHROME_BROWSER_CHOOSER_CONTROLLER_CHOOSER_CONTROLLER_H_
 
 #include <vector>
 
 #include "base/macros.h"
@@ skipping 112 matching lines @@
   // Open help center URL.
   virtual void OpenHelpCenterUrl() const = 0;
 
   // Provide help information when the adapter is off.
   virtual void OpenAdapterOffHelpUrl() const;
 
   // Only one view may be registered at a time.
   void set_view(View* view) { view_ = view; }
   View* view() const { return view_; }
 
+ protected:
+  void set_title(base::string16 title) { title_ = title; }

[Jeffrey Yasskin, 2017/06/15 22:06:30]

Either const base::string16& or std::move(title). I never remember which one our
style guide prefers.

[juncai, 2017/06/15 22:14:57]

drive-by comment: Since this function is only for testing, maybe add
"_for_testing" explicitly in its function name to be: "set_title_for_testing()".

[Peter Kasting, 2017/06/15 22:26:14]

Since I just looked this up an hour ago: we prefer passing strings by const ref
to pass-by-value-and-move.

[Bret, 2017/06/15 22:50:14]

All done.

+
  private:
   base::string16 title_;
   View* view_ = nullptr;
 
   DISALLOW_COPY_AND_ASSIGN(ChooserController);
 };
 
 #endif  // CHROME_BROWSER_CHOOSER_CONTROLLER_CHOOSER_CONTROLLER_H_