Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3207)

Unified Diff: chrome/browser/chooser_controller/chooser_controller.h

Issue 2932243002: Refactor ChooserDialogView to use borders instead of content margins. (Closed)
Patch Set: use constants for signal strength Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chooser_controller/chooser_controller.h
diff --git a/chrome/browser/chooser_controller/chooser_controller.h b/chrome/browser/chooser_controller/chooser_controller.h
index 33658c6ee8e405e567eb169f751bb35c030b7af3..0445af95ca0a73bddc9fd2391a3d2b44ab1d8da1 100644
--- a/chrome/browser/chooser_controller/chooser_controller.h
+++ b/chrome/browser/chooser_controller/chooser_controller.h
@@ -62,7 +62,7 @@ class ChooserController {
};
// Returns the text to be displayed in the chooser title.
- base::string16 GetTitle() const;
+ virtual base::string16 GetTitle() const;
Jeffrey Yasskin 2017/06/15 21:33:42 I'm a little unhappy with making this configurable
Bret 2017/06/15 21:54:42 It's so that MockChooserController can have a titl
// Returns if the chooser needs to show an icon before the text.
// For WebBluetooth, it is a signal strength icon.

Powered by Google App Engine
This is Rietveld 408576698