Refactor ChooserDialogView to use borders instead of content margins.

chrome/browser/chooser_controller/chooser_controller.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHOOSER_CONTROLLER_CHOOSER_CONTROLLER_H_
 #define CHROME_BROWSER_CHOOSER_CONTROLLER_CHOOSER_CONTROLLER_H_
 
 #include <vector>
 
 #include "base/macros.h"
@@ skipping 44 matching lines @@
     virtual void OnAdapterEnabledChanged(bool enabled) = 0;
 
     // Called when refreshing options is in progress or complete.
     virtual void OnRefreshStateChanged(bool refreshing) = 0;
 
    protected:
     virtual ~View() {}
   };
 
   // Returns the text to be displayed in the chooser title.
-  base::string16 GetTitle() const;
+  virtual base::string16 GetTitle() const;

[Jeffrey Yasskin, 2017/06/15 21:33:42]

I'm a little unhappy with making this configurable by subclasses, while still
providing the default implementation with a member variable in the base here.
Why do subclasses need to customize this?

[Bret, 2017/06/15 21:54:42]

It's so that MockChooserController can have a title for the browser test. But
you're right, it's a bit wonky. I changed it to a protected set_title method,
what do you think?

 
   // Returns if the chooser needs to show an icon before the text.
   // For WebBluetooth, it is a signal strength icon.
   virtual bool ShouldShowIconBeforeText() const;
 
   // Returns if the chooser needs to show a footnote view.
   virtual bool ShouldShowFootnoteView() const;
 
   // Returns if the chooser allows multiple items to be selected.
   virtual bool AllowMultipleSelection() const;
@@ skipping 55 matching lines @@
   View* view() const { return view_; }
 
  private:
   base::string16 title_;
   View* view_ = nullptr;
 
   DISALLOW_COPY_AND_ASSIGN(ChooserController);
 };
 
 #endif  // CHROME_BROWSER_CHOOSER_CONTROLLER_CHOOSER_CONTROLLER_H_