Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 2932223002: Revert of ChromeDriver: Handle key events properly on Mac (Closed)

Created:
3 years, 6 months ago by Nico
Modified:
3 years, 6 months ago
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ChromeDriver: Handle key events properly on Mac (patchset #6 id:440001 of https://codereview.chromium.org/2656903005/ ) Reason for revert: Speculative, might have caused https://crbug.com/732053 Original issue's description: > ChromeDriver: Handle key events properly on Mac > > Fixes devtool's emulation of key input events to emulate > os key event for OSX. > > BUG=667387 > > Review-Url: https://codereview.chromium.org/2656903005 > Cr-Commit-Position: refs/heads/master@{#478407} > Committed: https://chromium.googlesource.com/chromium/src/+/fa84ab9619de73a61d305c7459fc186e99b0d291 TBR=dgozman@chromium.org,rohitrao@chromium.org,pfeldman@chromium.org,luoe@chromium.org,erikchen@chromium.org,allada@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=667387 Review-Url: https://codereview.chromium.org/2932223002 Cr-Commit-Position: refs/heads/master@{#478518} Committed: https://chromium.googlesource.com/chromium/src/+/3505cba91e5a004726c286f4396caf2aae3c2e17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -208 lines) Patch
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 3 chunks +0 lines, -47 lines 0 comments Download
D chrome/test/data/devtools/dispatch_key_event_shows_auto_fill.html View 1 chunk +0 lines, -22 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/protocol/input_handler.cc View 3 chunks +2 lines, -3 lines 0 comments Download
D content/browser/devtools/protocol/native_input_event_builder.h View 1 chunk +0 lines, -30 lines 0 comments Download
D content/browser/devtools/protocol/native_input_event_builder_mac.mm View 1 chunk +0 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
Created Revert of ChromeDriver: Handle key events properly on Mac
3 years, 6 months ago (2017-06-10 18:10:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932223002/1
3 years, 6 months ago (2017-06-10 18:10:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3505cba91e5a004726c286f4396caf2aae3c2e17
3 years, 6 months ago (2017-06-10 18:11:08 UTC) #6
Nico
3 years, 6 months ago (2017-06-10 19:41:47 UTC) #7
Message was sent while issue was closed.
This helped.

Powered by Google App Engine
This is Rietveld 408576698