Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2932093002:
Remove PuChuangSiDa as a known Certificate Transparency Log (Closed)
|
Created:
3 years, 6 months ago by Ryan Sleevi Modified:
3 years, 6 months ago CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove PuChuangSiDa as a known Certificate Transparency Log
As noted on
https://groups.google.com/a/chromium.org/forum/#!topic/ct-policy/M-rhwDQ1h9E
, the log has failed to abide by the uptime requirement.
BUG=731836
TBR=eroman@chromium.org
Review-Url: https://codereview.chromium.org/2932093002
Cr-Commit-Position: refs/heads/master@{#478639}
Committed: https://chromium.googlesource.com/chromium/src/+/85bf190d18689ad2466771fb99b0d353aa25e5ae
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
rsleevi@chromium.org changed reviewers: + hadfieldp@chromium.org
Paul: Can you confirm there are no issues with removing from the JSON? I considered setting the last good SCT at 0, but that would mean carrying around the public key for the long in the Chrome binary, which did not seem appropriate. Alternatively, extending the syntax of the JSON was an option, but that schema seems externally maintained.
On 2017/06/09 19:25:40, Ryan Sleevi wrote: > Paul: Can you confirm there are no issues with removing from the JSON? > > I considered setting the last good SCT at 0, but that would mean carrying around > the public key for the long in the Chrome binary, which did not seem > appropriate. Alternatively, extending the syntax of the JSON was an option, but > that schema seems externally maintained. Ryan, it'll be fine to remove the log and its operator as you have done.
The CQ bit was checked by hadfieldp@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by rsleevi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Remove PuChuangSiDa as a known Certificate Transparency Log As noted on https://groups.google.com/a/chromium.org/forum/#!topic/ct-policy/M-rhwDQ1h9E , the log has failed to abide by the uptime requirement. BUG=731836 ========== to ========== Remove PuChuangSiDa as a known Certificate Transparency Log As noted on https://groups.google.com/a/chromium.org/forum/#!topic/ct-policy/M-rhwDQ1h9E , the log has failed to abide by the uptime requirement. BUG=731836 TBR=eroman@chromium.org ==========
rsleevi@chromium.org changed reviewers: + eroman@chromium.org
eroman: TBR a data file change
The CQ bit was checked by rsleevi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1497277597288560, "parent_rev":
"e09ad54e01d9a94d9bc0480ed7f696f2ca188143", "commit_rev":
"85bf190d18689ad2466771fb99b0d353aa25e5ae"}
Message was sent while issue was closed.
Description was changed from ========== Remove PuChuangSiDa as a known Certificate Transparency Log As noted on https://groups.google.com/a/chromium.org/forum/#!topic/ct-policy/M-rhwDQ1h9E , the log has failed to abide by the uptime requirement. BUG=731836 TBR=eroman@chromium.org ========== to ========== Remove PuChuangSiDa as a known Certificate Transparency Log As noted on https://groups.google.com/a/chromium.org/forum/#!topic/ct-policy/M-rhwDQ1h9E , the log has failed to abide by the uptime requirement. BUG=731836 TBR=eroman@chromium.org Review-Url: https://codereview.chromium.org/2932093002 Cr-Commit-Position: refs/heads/master@{#478639} Committed: https://chromium.googlesource.com/chromium/src/+/85bf190d18689ad2466771fb99b0... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/85bf190d18689ad2466771fb99b0...
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
