Clean up DCHECKs in MediaStreamAudioProcessor

Clean up DCHECKs in MediaStreamAudioProcessor

In http://crrev/2699113002, MediaStreamAudioProcessor was made to
always register itself as a WebRtcPlayoutDataSource::Sink in
AudioDeviceImpl, independently of doing echo cancellation or
not. DCHECKs were left in MediaStreamAudioProcessor::OnPlayoutData
that checked that echo cancellation was active. That is an invalid
assumption, because we always want to register the
MediaStreamAudioProcessor and run audio through
webrtc::AudioProcessingModule (which has other functionality but echo
cancellation, e.g. noise suppression or echo detection). The
assumption that echo cancellation is active is not used anywhere else
in the code.

This CL removes these DCHECKs.

BUG=702441
Review-Url: https://codereview.chromium.org/2932063002
Cr-Commit-Position: refs/heads/master@{#478241}
Committed: https://chromium.googlesource.com/chromium/src/+/0729944af28ece2d2a2c215de01ecc2dba29a7e3

[aleloi2, 2017-06-09 07:50:07]

The CQ bit was checked by aleloi@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 07:50:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleloi2, 2017-06-09 07:50:49]

aleloi@google.com changed reviewers:
+ hbos@chromium.org

[aleloi2, 2017-06-09 07:50:50]

Hi, can you PTAL?

[hbos_chromium, 2017-06-09 07:58:00]

lgtm

[commit-bot: I haz the power, 2017-06-09 09:36:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 09:36:46]

Dry run: This issue passed the CQ dry run.

[aleloi2, 2017-06-09 10:32:51]

The CQ bit was checked by aleloi@google.com

[commit-bot: I haz the power, 2017-06-09 10:33:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 10:37:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497004371299470, "parent_rev":
"7405410d7e2280ae94a742af005204ef24d085b5", "commit_rev":
"0729944af28ece2d2a2c215de01ecc2dba29a7e3"}

[commit-bot: I haz the power, 2017-06-09 10:38:08]

Description was changed from

==========
Clean up DCHECKs in MediaStreamAudioProcessor

In http://crrev/2699113002, MediaStreamAudioProcessor was made to
always register itself as a WebRtcPlayoutDataSource::Sink in
AudioDeviceImpl, independently of doing echo cancellation or
not. DCHECKs were left in MediaStreamAudioProcessor::OnPlayoutData
that checked that echo cancellation was active. That is an invalid
assumption, because we always want to register the
MediaStreamAudioProcessor and run audio through
webrtc::AudioProcessingModule (which has other functionality but echo
cancellation, e.g. noise suppression or echo detection). The
assumption that echo cancellation is active is not used anywhere else
in the code.

This CL removes these DCHECKs.

BUG=702441
==========

to

==========
Clean up DCHECKs in MediaStreamAudioProcessor

In http://crrev/2699113002, MediaStreamAudioProcessor was made to
always register itself as a WebRtcPlayoutDataSource::Sink in
AudioDeviceImpl, independently of doing echo cancellation or
not. DCHECKs were left in MediaStreamAudioProcessor::OnPlayoutData
that checked that echo cancellation was active. That is an invalid
assumption, because we always want to register the
MediaStreamAudioProcessor and run audio through
webrtc::AudioProcessingModule (which has other functionality but echo
cancellation, e.g. noise suppression or echo detection). The
assumption that echo cancellation is active is not used anywhere else
in the code.

This CL removes these DCHECKs.

BUG=702441

Review-Url: https://codereview.chromium.org/2932063002
Cr-Commit-Position: refs/heads/master@{#478241}
Committed:
https://chromium.googlesource.com/chromium/src/+/0729944af28ece2d2a2c215de01e...
==========

[commit-bot: I haz the power, 2017-06-09 10:38:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0729944af28ece2d2a2c215de01e...