Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2932053003: [ash] Made TriView's re-layout automatically when a child container's visibility changes. (Closed)

Created:
3 years, 6 months ago by bruthig
Modified:
3 years, 6 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash] Made TriView's re-layout automatically when a child container's visibility changes. BUG=720581 TEST=ash_unittests --gtest_filter=TriViewTest* Review-Url: https://codereview.chromium.org/2932053003 Cr-Commit-Position: refs/heads/master@{#478418} Committed: https://chromium.googlesource.com/chromium/src/+/063c6c51120102374631bd44e180511e8e076670

Patch Set 1 #

Patch Set 2 : Fixed compile error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M ash/system/audio/volume_view.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/tray/tri_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/tray/tri_view.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/tray/tri_view_unittest.cc View 1 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
bruthig
tdanderson@, can you PTAL?
3 years, 6 months ago (2017-06-09 20:11:26 UTC) #9
tdanderson
LGTM
3 years, 6 months ago (2017-06-09 21:11:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932053003/20001
3 years, 6 months ago (2017-06-09 21:13:55 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 21:21:31 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/063c6c51120102374631bd44e180...

Powered by Google App Engine
This is Rietveld 408576698