third_party/crashpad/crashpad/minidump/minidump_extensions.h - Issue 2932053002: Use C++11 alignment primitives

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/minidump/minidump_extensions.h

Issue 2932053002: Use C++11 alignment primitives (Closed)

Patch Set: Format Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/crashpad/crashpad/minidump/minidump_extensions.h

diff --git a/third_party/crashpad/crashpad/minidump/minidump_extensions.h b/third_party/crashpad/crashpad/minidump/minidump_extensions.h

index 245ef8b5baa563f4e14a7f64e47a6b94b3765490..0cad9d543523a2bfd349fe6032080f1d04c1c615 100644

--- a/third_party/crashpad/crashpad/minidump/minidump_extensions.h

+++ b/third_party/crashpad/crashpad/minidump/minidump_extensions.h

@@ -102,7 +102,7 @@ enum MinidumpStreamType : uint32_t {

//! file.

//!

//! \sa MINIDUMP_STRING

-struct ALIGNAS(4) PACKED MinidumpUTF8String {

+struct alignas(4) PACKED MinidumpUTF8String {

scottmg 2017/06/09 19:49:01 There's a bunch more ALIGNAS in this file. I can

// The field names do not conform to typical style, they match the names used

// in MINIDUMP_STRING. This makes it easier to operate on MINIDUMP_STRING (for

// UTF-16 strings) and MinidumpUTF8String using templates.