Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: third_party/crashpad/crashpad/minidump/minidump_extensions.h

Issue 2932053002: Use C++11 alignment primitives (Closed)
Patch Set: Format Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 // 0x4350 = "CP" 95 // 0x4350 = "CP"
96 96
97 //! \brief The stream type for MinidumpCrashpadInfo. 97 //! \brief The stream type for MinidumpCrashpadInfo.
98 kMinidumpStreamTypeCrashpadInfo = 0x43500001, 98 kMinidumpStreamTypeCrashpadInfo = 0x43500001,
99 }; 99 };
100 100
101 //! \brief A variable-length UTF-8-encoded string carried within a minidump 101 //! \brief A variable-length UTF-8-encoded string carried within a minidump
102 //! file. 102 //! file.
103 //! 103 //!
104 //! \sa MINIDUMP_STRING 104 //! \sa MINIDUMP_STRING
105 struct ALIGNAS(4) PACKED MinidumpUTF8String { 105 struct alignas(4) PACKED MinidumpUTF8String {
scottmg 2017/06/09 19:49:01 There's a bunch more ALIGNAS in this file. I can
106 // The field names do not conform to typical style, they match the names used 106 // The field names do not conform to typical style, they match the names used
107 // in MINIDUMP_STRING. This makes it easier to operate on MINIDUMP_STRING (for 107 // in MINIDUMP_STRING. This makes it easier to operate on MINIDUMP_STRING (for
108 // UTF-16 strings) and MinidumpUTF8String using templates. 108 // UTF-16 strings) and MinidumpUTF8String using templates.
109 109
110 //! \brief The length of the #Buffer field in bytes, not including the `NUL` 110 //! \brief The length of the #Buffer field in bytes, not including the `NUL`
111 //! terminator. 111 //! terminator.
112 //! 112 //!
113 //! \note This field is interpreted as a byte count, not a count of Unicode 113 //! \note This field is interpreted as a byte count, not a count of Unicode
114 //! code points. 114 //! code points.
115 uint32_t Length; 115 uint32_t Length;
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 #if defined(COMPILER_MSVC) 441 #if defined(COMPILER_MSVC)
442 #pragma pack(pop) 442 #pragma pack(pop)
443 #endif // COMPILER_MSVC 443 #endif // COMPILER_MSVC
444 #undef PACKED 444 #undef PACKED
445 445
446 MSVC_POP_WARNING(); // C4200 446 MSVC_POP_WARNING(); // C4200
447 447
448 } // namespace crashpad 448 } // namespace crashpad
449 449
450 #endif // CRASHPAD_MINIDUMP_MINIDUMP_EXTENSIONS_H_ 450 #endif // CRASHPAD_MINIDUMP_MINIDUMP_EXTENSIONS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698