Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2932043002: Printing: Remove check for Windows RPCS printers (Closed)

Created:
3 years, 6 months ago by rbpotter
Modified:
3 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Printing: Remove check for Windows RPCS printers Now that we check for invalid paper sizes, we no longer need the RPCS driver check to prevent crashes on Win10. This will also fix breakage of Japanese RPCS drivers that support Win10. BUG=730919 Review-Url: https://codereview.chromium.org/2932043002 Cr-Commit-Position: refs/heads/master@{#478172} Committed: https://chromium.googlesource.com/chromium/src/+/685631bcd8b90950498e80f74009660ea5f75010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M printing/backend/win_helper.cc View 2 chunks +3 lines, -18 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
rbpotter
3 years, 6 months ago (2017-06-09 01:13:04 UTC) #3
Lei Zhang
lgtm For the first line of the CL description, how about: Remove check for Windows ...
3 years, 6 months ago (2017-06-09 01:24:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932043002/1
3 years, 6 months ago (2017-06-09 02:44:15 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 02:49:09 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/685631bcd8b90950498e80f74009...

Powered by Google App Engine
This is Rietveld 408576698