Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2932033003: [Test]Swiping on system tray bubble. (Closed)

Created:
3 years, 6 months ago by minch1
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Swiping on system tray bubble. Swiping up on the system tray should open the system tray bubble. 1.Change the bounds of the bubble according to the position of the gesture. 2.For SCROLL_END event. Whether to show or hide the bubble depends on the position of the gesture. Bubble is split into three parts. End in the lowest part will hide the bubble; End in the highest part will show the bubble; End in the middle part depends on the scroll delta of the final gesture. 3.For FLING event. Whether to show or hide the bubble depends on gesture position and velocity. If the fling velocity larger than |kSwipingVelocity|, show or hide according to the fling direction; Otherwise, show or hide depends on the position. 4.The rules maybe changed later. No animation currently. BUG=725977

Patch Set 1 #

Patch Set 2 : Swiping on system tray bubble. #

Patch Set 3 : Rebased. #

Patch Set 4 : Remove shell observer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -6 lines) Patch
M ash/system/tray/system_tray.h View 1 4 chunks +44 lines, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 1 2 3 7 chunks +127 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 1 chunk +16 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (18 generated)
nodir
3 years, 6 months ago (2017-06-09 17:44:31 UTC) #10
please ignore the "LUCI chromium_presubmit". CQ will ignore it too. It should
have been marked experimental.

Powered by Google App Engine
This is Rietveld 408576698