Refactor LoopHandler to avoid calling KernelAstAdapter.getNode

Refactor LoopHandler to avoid calling KernelAstAdapter.getNode

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/52b1ea04e8974e83b23cf0917925254af754b301

[Johnni Winther, 2017-06-09 19:56:08]

johnniwinther@google.com changed reviewers:
+ efortuna@google.com

[Johnni Winther, 2017-06-09 19:56:09]

I hope this doesn't conflict with your refactorings.

[Emily Fortuna, 2017-06-09 20:12:27]

check out my comments first....

https://codereview.chromium.org/2932023003/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/2932023003/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder.dart:1748: localsHandler.startLoop(scopeData);
great minds think alike?

I actually have a CL that does this same thing (passing in the data instead of
the node) that I was working on yesterday evening, but didn't send out yet for
review: https://codereview.chromium.org/2932103002 

So... maybe hold off on this part? I didn't do the change about making the
localsMap non-private though, so that could go in. I should have this other CL
ready for review by EOD today, so you can take a look -- it's in a similar but
slightly different direction than this one, so I welcome your input.

https://codereview.chromium.org/2932023003/diff/1/pkg/compiler/lib/src/ssa/lo...
File pkg/compiler/lib/src/ssa/locals_handler.dart (right):

https://codereview.chromium.org/2932023003/diff/1/pkg/compiler/lib/src/ssa/lo...
pkg/compiler/lib/src/ssa/locals_handler.dart:477: //ClosureScope scopeData =
closureData.capturingScopes[node];
delete line?

https://codereview.chromium.org/2932023003/diff/1/pkg/compiler/lib/src/ssa/lo...
pkg/compiler/lib/src/ssa/locals_handler.dart:512: //ClosureScope scopeData =
closureData.capturingScopes[node];
same here

https://codereview.chromium.org/2932023003/diff/1/pkg/compiler/lib/src/ssa/lo...
pkg/compiler/lib/src/ssa/locals_handler.dart:527: //ClosureScope scopeData =
closureData.capturingScopes[node];
ditto

[Johnni Winther, 2017-06-12 08:02:52]

https://codereview.chromium.org/2932023003/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/2932023003/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder.dart:1748: localsHandler.startLoop(scopeData);
On 2017/06/09 20:12:26, Emily Fortuna wrote:
> great minds think alike?
> 
> I actually have a CL that does this same thing (passing in the data instead of
> the node) that I was working on yesterday evening, but didn't send out yet for
> review: https://codereview.chromium.org/2932103002 
> 
> So... maybe hold off on this part? I didn't do the change about making the
> localsMap non-private though, so that could go in. I should have this other CL
> ready for review by EOD today, so you can take a look -- it's in a similar but
> slightly different direction than this one, so I welcome your input.

I'll wait for your CL to land

[Johnni Winther, 2017-06-13 09:57:31]

PTAL

[Emily Fortuna, 2017-06-13 17:25:23]

lgtm! (and thanks for waiting)

[Johnni Winther, 2017-06-14 10:18:44]

Description was changed from

==========
Refactor LoopHandler to avoid calling KernelAstAdapter.getNode
==========

to

==========
Refactor LoopHandler to avoid calling KernelAstAdapter.getNode

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/52b1ea04e8974e83b23cf0917925254af754b301
==========

[Johnni Winther, 2017-06-14 10:18:46]

Committed patchset #3 (id:40001) manually as
52b1ea04e8974e83b23cf0917925254af754b301 (presubmit successful).