Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Issue 2932103002: Separate out loop closure information. (Closed)

Created:
3 years, 6 months ago by Emily Fortuna
Modified:
3 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : . #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -64 lines) Patch
M pkg/compiler/lib/src/closure.dart View 6 chunks +48 lines, -3 lines 4 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 9 chunks +48 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 9 chunks +55 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 4 chunks +22 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/ssa/loop_handler.dart View 8 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Emily Fortuna
3 years, 6 months ago (2017-06-10 01:10:55 UTC) #5
Johnni Winther
lgtm https://codereview.chromium.org/2932103002/diff/60001/pkg/compiler/lib/src/closure.dart File pkg/compiler/lib/src/closure.dart (right): https://codereview.chromium.org/2932103002/diff/60001/pkg/compiler/lib/src/closure.dart#newcode77 pkg/compiler/lib/src/closure.dart:77: /// var list = [] var list = ...
3 years, 6 months ago (2017-06-12 08:04:38 UTC) #6
Emily Fortuna
https://codereview.chromium.org/2932103002/diff/60001/pkg/compiler/lib/src/closure.dart File pkg/compiler/lib/src/closure.dart (right): https://codereview.chromium.org/2932103002/diff/60001/pkg/compiler/lib/src/closure.dart#newcode77 pkg/compiler/lib/src/closure.dart:77: /// var list = [] On 2017/06/12 08:04:38, Johnni ...
3 years, 6 months ago (2017-06-12 17:05:33 UTC) #7
Emily Fortuna
3 years, 6 months ago (2017-06-12 17:07:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:60001) manually as
5636a225d7a2f49136fb336c26f6f7f479800129 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698