Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2932013002: Add examples for some scenarios in the code review docs. (Closed)

Created:
3 years, 6 months ago by Lei Zhang
Modified:
3 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add examples for some scenarios in the code review docs. - Example for picking more specific owners. - Example for TBRing mechanical changes. - Remind developers to tell TBR reviewers what they are being TBR'd for. Review-Url: https://codereview.chromium.org/2932013002 Cr-Commit-Position: refs/heads/master@{#478433} Committed: https://chromium.googlesource.com/chromium/src/+/9208d8ba4573a393b9b034555757cb8252a89c0b

Patch Set 1 #

Patch Set 2 : add some suggestions #

Patch Set 3 : add some suggestions #

Patch Set 4 : examples, we love examples #

Patch Set 5 : format #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -12 lines) Patch
M docs/code_reviews.md View 1 2 3 4 3 chunks +30 lines, -12 lines 2 comments Download

Messages

Total messages: 10 (5 generated)
Lei Zhang
Brett, can you take a look since you put this doc together originally?
3 years, 6 months ago (2017-06-09 01:45:03 UTC) #3
brettw
lgtm https://codereview.chromium.org/2932013002/diff/100001/docs/code_reviews.md File docs/code_reviews.md (right): https://codereview.chromium.org/2932013002/diff/100001/docs/code_reviews.md#newcode122 docs/code_reviews.md:122: ``` I'm not sure gitiles will do what ...
3 years, 6 months ago (2017-06-09 15:31:17 UTC) #4
Lei Zhang
https://codereview.chromium.org/2932013002/diff/100001/docs/code_reviews.md File docs/code_reviews.md (right): https://codereview.chromium.org/2932013002/diff/100001/docs/code_reviews.md#newcode122 docs/code_reviews.md:122: ``` On 2017/06/09 15:31:17, brettw wrote: > I'm not ...
3 years, 6 months ago (2017-06-09 21:52:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932013002/100001
3 years, 6 months ago (2017-06-09 21:53:13 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 22:05:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/9208d8ba4573a393b9b034555757...

Powered by Google App Engine
This is Rietveld 408576698