Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9128)

Unified Diff: build/config/BUILDCONFIG.gn

Issue 2931983003: Move libc++ configs and flags out of //build/config/sanitizers (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/BUILDCONFIG.gn
diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
index 38a6119db8320b91b297458d77521a1465ccdacb..144aa3ac5c74336364d6ded1b03d1fe08e27c049 100644
--- a/build/config/BUILDCONFIG.gn
+++ b/build/config/BUILDCONFIG.gn
@@ -519,6 +519,7 @@ default_compiler_configs = [
"//build/config/compiler:default_symbols",
"//build/config/compiler:no_rtti",
"//build/config/compiler:runtime_library",
+ "//build/config/libc++:libc++flags",
brettw 2017/06/12 17:55:18 The reason things need to go here is that targets
Tom Anderson 2017/06/16 20:49:50 I think (maybe) cronet needs to remove it so it ca
brettw 2017/06/19 23:40:26 Your current patch doesn't implement this. Since w
"//build/config/sanitizers:default_sanitizer_flags",
]
if (is_win) {

Powered by Google App Engine
This is Rietveld 408576698