Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2931983002:
Mojo JS bindings: specify compress="gzip" for bindings JS files in .grd. (Closed)
DescriptionMojo JS bindings: specify compress="gzip" for bindings JS files in .grd.
Numbers measured using a Release Android build:
=====================================
Before:
Analyzing pak files in out/ARelease/apks/MonochromePublic.apk...
Total pak files: 99
Total compressed size: 5.10m
Total uncompressed size: 9.93m
...
====================================
After:
Analyzing pak files in out/ARelease/apks/MonochromePublic.apk...
Total pak files: 99
Total compressed size: 5.01m
Total uncompressed size: 9.84m
...
===================================
BUG=731243
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2931983002
Cr-Commit-Position: refs/heads/master@{#478233}
Committed: https://chromium.googlesource.com/chromium/src/+/1a4797788c3fd17e40f37aa0379b148c38461bba
Patch Set 1 #Patch Set 2 : . #
Total comments: 2
Patch Set 3 : . #
Messages
Total messages: 27 (19 generated)
Description was changed from ========== Mojo JS bindings: specify compress="gzip" for bindings JS files in .grd. Numbers measured using a Release Android build: ===================================== Before: Analyzing pak files in out/ARelease/apks/MonochromePublic.apk... Total pak files: 99 Total compressed size: 5.10m Total uncompressed size: 9.93m ... ==================================== After: Analyzing pak files in out/ARelease/apks/MonochromePublic.apk... Total pak files: 99 Total compressed size: 4.92m Total uncompressed size: 9.76m ... =================================== BUG=731243 ========== to ========== Mojo JS bindings: specify compress="gzip" for bindings JS files in .grd. Numbers measured using a Release Android build: ===================================== Before: Analyzing pak files in out/ARelease/apks/MonochromePublic.apk... Total pak files: 99 Total compressed size: 5.10m Total uncompressed size: 9.93m ... ==================================== After: Analyzing pak files in out/ARelease/apks/MonochromePublic.apk... Total pak files: 99 Total compressed size: 4.92m Total uncompressed size: 9.76m ... =================================== BUG=731243 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by yzshen@chromium.org to run a CQ dry run
The CQ bit was unchecked by yzshen@chromium.org
The CQ bit was checked by yzshen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yzshen@chromium.org changed reviewers: + sky@chromium.org
Hi, Scott. Would you please take a look? Thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
LGTM
Description was changed from ========== Mojo JS bindings: specify compress="gzip" for bindings JS files in .grd. Numbers measured using a Release Android build: ===================================== Before: Analyzing pak files in out/ARelease/apks/MonochromePublic.apk... Total pak files: 99 Total compressed size: 5.10m Total uncompressed size: 9.93m ... ==================================== After: Analyzing pak files in out/ARelease/apks/MonochromePublic.apk... Total pak files: 99 Total compressed size: 4.92m Total uncompressed size: 9.76m ... =================================== BUG=731243 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Mojo JS bindings: specify compress="gzip" for bindings JS files in .grd. Numbers measured using a Release Android build: ===================================== Before: Analyzing pak files in out/ARelease/apks/MonochromePublic.apk... Total pak files: 99 Total compressed size: 5.10m Total uncompressed size: 9.93m ... ==================================== After: Analyzing pak files in out/ARelease/apks/MonochromePublic.apk... Total pak files: 99 Total compressed size: 5.01m Total uncompressed size: 9.84m ... =================================== BUG=731243 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
yzshen@chromium.org changed reviewers: + dpapad@chromium.org
The CQ bit was checked by yzshen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by yzshen@chromium.org
Thanks, Scott! I realized that I needed C++ changes too. Also +Demetrios as reviewer.
dpapad@chromium.org changed reviewers: + dbeam@chromium.org
Deferring to dbeam@ (while still with us), who is more familiar with the WebUI's gzip mechanism.
dpapad@chromium.org changed reviewers: - dpapad@chromium.org
lgtm w/ simplification https://codereview.chromium.org/2931983002/diff/20001/content/browser/webui/s... File content/browser/webui/shared_resources_data_source.cc (right): https://codereview.chromium.org/2931983002/diff/20001/content/browser/webui/s... content/browser/webui/shared_resources_data_source.cc:218: return gzipped_path_set.find(path) != gzipped_path_set.end(); can't this all just be return path == "js/mojo_bindings.js"; until you have 2+ items?
https://codereview.chromium.org/2931983002/diff/20001/content/browser/webui/s... File content/browser/webui/shared_resources_data_source.cc (right): https://codereview.chromium.org/2931983002/diff/20001/content/browser/webui/s... content/browser/webui/shared_resources_data_source.cc:218: return gzipped_path_set.find(path) != gzipped_path_set.end(); On 2017/06/09 01:05:28, Dan Beam wrote: > can't this all just be > > return path == "js/mojo_bindings.js"; > > until you have 2+ items? Yes. It can. :) Done.
The CQ bit was checked by yzshen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org, dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2931983002/#ps40001 (title: ".")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496992035254320,
"parent_rev": "2ffea18a09d72a6cfdc68445f3fd0174de2dbc40", "commit_rev":
"1a4797788c3fd17e40f37aa0379b148c38461bba"}
Message was sent while issue was closed.
Description was changed from ========== Mojo JS bindings: specify compress="gzip" for bindings JS files in .grd. Numbers measured using a Release Android build: ===================================== Before: Analyzing pak files in out/ARelease/apks/MonochromePublic.apk... Total pak files: 99 Total compressed size: 5.10m Total uncompressed size: 9.93m ... ==================================== After: Analyzing pak files in out/ARelease/apks/MonochromePublic.apk... Total pak files: 99 Total compressed size: 5.01m Total uncompressed size: 9.84m ... =================================== BUG=731243 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Mojo JS bindings: specify compress="gzip" for bindings JS files in .grd. Numbers measured using a Release Android build: ===================================== Before: Analyzing pak files in out/ARelease/apks/MonochromePublic.apk... Total pak files: 99 Total compressed size: 5.10m Total uncompressed size: 9.93m ... ==================================== After: Analyzing pak files in out/ARelease/apks/MonochromePublic.apk... Total pak files: 99 Total compressed size: 5.01m Total uncompressed size: 9.84m ... =================================== BUG=731243 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2931983002 Cr-Commit-Position: refs/heads/master@{#478233} Committed: https://chromium.googlesource.com/chromium/src/+/1a4797788c3fd17e40f37aa0379b... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/1a4797788c3fd17e40f37aa0379b... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
