Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2931943003: Add scripts dependency to net_perftests target (Closed)

Created:
3 years, 6 months ago by xunjieli
Modified:
3 years, 6 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add scripts dependency to net_perftests target The scripts dependency is needed for net_perftests to run on the bot. See linked bug for more details. BUG=731694 Review-Url: https://codereview.chromium.org/2931943003 Cr-Commit-Position: refs/heads/master@{#478335} Committed: https://chromium.googlesource.com/chromium/src/+/5a866840ec589cd768ced41418bc2d89554e05ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M net/BUILD.gn View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
xunjieli
Ned, PTAL. Thanks.
3 years, 6 months ago (2017-06-09 16:56:51 UTC) #2
nednguyen
lgtm
3 years, 6 months ago (2017-06-09 17:09:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931943003/1
3 years, 6 months ago (2017-06-09 17:35:45 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 18:16:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5a866840ec589cd768ced41418bc...

Powered by Google App Engine
This is Rietveld 408576698