Issue 2931943002: Disable permissions dialog in VR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2931943002: Disable permissions dialog in VR (Closed)

Created:
3 years, 6 months ago by asimjour1

Modified:
3 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

Disable permissions dialog in VR When in VR, permission request will be disabled so the user will not be able to give new permissions. BUG=715613 (cherry picked from commit b30c2b98a02322dcd366783977b3bc3fc7554ea1) Review-Url: https://codereview.chromium.org/2931943002 . Cr-Commit-Position: refs/branch-heads/3112@{#260} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/f3c39a79f71c6e079af5786a672162ccd5a3303e

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -6 lines)			Patch
M	chrome/browser/android/vr_shell/vr_tab_helper.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/permissions/permission_manager.cc	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/permissions/permission_manager_unittest.cc	View	6 chunks	+61 lines, -6 lines	0 comments	Download

Total messages: 2 (1 generated)

asimjour1

3 years, 6 months ago (2017-06-08 18:36:58 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f3c39a79f71c6e079af5786a672162ccd5a3303e.