Report an error when a part-of refers to an unnamed library.

pkg/analyzer/test/src/dart/analysis/driver_test.dart

Index: pkg/analyzer/test/src/dart/analysis/driver_test.dart
diff --git a/pkg/analyzer/test/src/dart/analysis/driver_test.dart b/pkg/analyzer/test/src/dart/analysis/driver_test.dart
index 8985c013873e4675cfc84b166d86a00cc40a8f39..2ae413bd2802a3dd6d3eb1bb3eab27155794f04a 100644
--- a/pkg/analyzer/test/src/dart/analysis/driver_test.dart
+++ b/pkg/analyzer/test/src/dart/analysis/driver_test.dart
@@ -503,8 +503,8 @@ part of lib;
     AnalysisResult libResult = await driver.getResult(lib);
     List<AnalysisError> errors = libResult.errors;
     if (libResult.unit.element.context.analysisOptions.enableUriInPartOf) {
-      // TODO(28522): Should cause an error for wrong library name.
-      expect(errors, hasLength(0));
+      expect(errors, hasLength(1));
+      expect(errors[0].errorCode, ResolverErrorCode.PART_OF_UNNAMED_LIBRARY);
     } else {
       expect(errors, hasLength(1));
       expect(errors[0].errorCode,
@@ -558,6 +558,28 @@ part of 'other_lib.dart';
     expect(errors[0].errorCode, StaticWarningCode.PART_OF_DIFFERENT_LIBRARY);
   }
 
+  test_analyze_resolveDirectives_error_partOfUnnamedLibrary_byName() async {

[Brian Wilkerson, 2017/06/08 19:54:23]

I'm probably blind, but aside from the name of the library in the part of
directive ('lib1') and the fact that this test isn't conditional based on
whether uri-in-part-of is enabled, this test appears to be identical to
test_analyze_resolveDirectives_error_missingLibraryDirective. Am I missing
something?

[floitsch, 2017/06/09 12:32:34]

No. I just wrote this test first, and then had to go back and fix the failing
test above.
I didn't take the time to see if there were more differences. ("More tests:
great!"). You are right, though. The second test doesn't add anything.

Removed.

+    var lib = _p('/test/lib.dart');
+    var part = _p('/test/part.dart');
+    provider.newFile(
+        lib,
+        '''
+part 'part.dart';
+''');
+    provider.newFile(
+        part,
+        '''
+part of lib1;
+''');
+
+    driver.addFile(lib);
+
+    AnalysisResult libResult = await driver.getResult(lib);
+    List<AnalysisError> errors = libResult.errors;
+    expect(errors, hasLength(1));
+    expect(errors[0].errorCode, ResolverErrorCode.PART_OF_UNNAMED_LIBRARY);
+  }
+
   test_analyze_resolveDirectives_error_partOfNonPart() async {
     var lib = _p('/test/lib.dart');
     var part = _p('/test/part.dart');