Report an error when a part-of refers to an unnamed library.

pkg/analyzer/test/src/dart/analysis/driver_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/standard_resolution_map.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
@@ skipping 485 matching lines @@
         part,
         '''
 part of lib;
 ''');
 
     driver.addFile(lib);
 
     AnalysisResult libResult = await driver.getResult(lib);
     List<AnalysisError> errors = libResult.errors;
     if (libResult.unit.element.context.analysisOptions.enableUriInPartOf) {
-      // TODO(28522): Should cause an error for wrong library name.
-      expect(errors, hasLength(0));
+      expect(errors, hasLength(1));
+      expect(errors[0].errorCode, ResolverErrorCode.PART_OF_UNNAMED_LIBRARY);
     } else {
       expect(errors, hasLength(1));
       expect(errors[0].errorCode,
           ResolverErrorCode.MISSING_LIBRARY_DIRECTIVE_WITH_PART);
     }
   }
 
   test_analyze_resolveDirectives_error_partOfDifferentLibrary_byName() async {
     var lib = _p('/test/lib.dart');
     var part = _p('/test/part.dart');
@@ skipping 33 matching lines @@
 ''');
 
     driver.addFile(lib);
 
     AnalysisResult libResult = await driver.getResult(lib);
     List<AnalysisError> errors = libResult.errors;
     expect(errors, hasLength(1));
     expect(errors[0].errorCode, StaticWarningCode.PART_OF_DIFFERENT_LIBRARY);
   }
 
+  test_analyze_resolveDirectives_error_partOfUnnamedLibrary_byName() async {

[Brian Wilkerson, 2017/06/08 19:54:23]

I'm probably blind, but aside from the name of the library in the part of
directive ('lib1') and the fact that this test isn't conditional based on
whether uri-in-part-of is enabled, this test appears to be identical to
test_analyze_resolveDirectives_error_missingLibraryDirective. Am I missing
something?

[floitsch, 2017/06/09 12:32:34]

No. I just wrote this test first, and then had to go back and fix the failing
test above.
I didn't take the time to see if there were more differences. ("More tests:
great!"). You are right, though. The second test doesn't add anything.

Removed.

+    var lib = _p('/test/lib.dart');
+    var part = _p('/test/part.dart');
+    provider.newFile(
+        lib,
+        '''
+part 'part.dart';
+''');
+    provider.newFile(
+        part,
+        '''
+part of lib1;
+''');
+
+    driver.addFile(lib);
+
+    AnalysisResult libResult = await driver.getResult(lib);
+    List<AnalysisError> errors = libResult.errors;
+    expect(errors, hasLength(1));
+    expect(errors[0].errorCode, ResolverErrorCode.PART_OF_UNNAMED_LIBRARY);
+  }
+
   test_analyze_resolveDirectives_error_partOfNonPart() async {
     var lib = _p('/test/lib.dart');
     var part = _p('/test/part.dart');
     provider.newFile(
         lib,
         '''
 library lib;
 part 'part.dart';
 ''');
     provider.newFile(
@@ skipping 2217 matching lines @@
     var path = _p('/test.dart');
     expect(() {
       driver.removeFile(path);
     }, throwsStateError);
   }
 
   String _p(String path) => provider.convertPath(path);
 }
 
 class _SourceMock extends TypedMock implements Source {}