Report an error when a part-of refers to an unnamed library.

Report an error when a part-of refers to an unnamed library.

Fixes #28522
BUG= http://dartbug.com/28522
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/377093841f1768537548e8cdb68b87dd3403b8dd

[floitsch, 2017-06-08 19:22:34]

floitsch@google.com changed reviewers:
+ brianwilkerson@google.com

[floitsch, 2017-06-08 19:22:35]

Not sure if it should be a warning or error. Lasse?
Would be easy to change.

[Lasse Reichstein Nielsen, 2017-06-08 19:31:18]

lrn@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2017-06-08 19:31:19]

It used to be an error, so keep it as one.

https://codereview.chromium.org/2931893004/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart (right):

https://codereview.chromium.org/2931893004/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart:489:
StaticWarningCode.PART_OF_UNNAMED_LIBRARY, partUri, [name]);
Logic seems backwards.
Put the second branch first:
  if (libraryNameNode == null) { 
    ...
  } else if (libraryNameNode.name != name) {
    ...
  }

[Lasse Reichstein Nielsen, 2017-06-08 19:34:34]

That said, I'm not sure the VM checks anything, which would suggest that it's a
warning (the VM doesn't do warnings).

In the long run, it should probably be an error, so make it one now, and if
necessary, we can scale it down until Dart 2.0.

[floitsch, 2017-06-08 19:47:33]

https://codereview.chromium.org/2931893004/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart (right):

https://codereview.chromium.org/2931893004/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart:489:
StaticWarningCode.PART_OF_UNNAMED_LIBRARY, partUri, [name]);
On 2017/06/08 19:31:19, Lasse Reichstein Nielsen wrote:
> Logic seems backwards.
> Put the second branch first:
>   if (libraryNameNode == null) { 
>     ...
>   } else if (libraryNameNode.name != name) {
>     ...
>   }

Done.

[Brian Wilkerson, 2017-06-08 19:54:23]

lgtm

https://codereview.chromium.org/2931893004/diff/20001/pkg/analyzer/test/src/d...
File pkg/analyzer/test/src/dart/analysis/driver_test.dart (right):

https://codereview.chromium.org/2931893004/diff/20001/pkg/analyzer/test/src/d...
pkg/analyzer/test/src/dart/analysis/driver_test.dart:561:
test_analyze_resolveDirectives_error_partOfUnnamedLibrary_byName() async {
I'm probably blind, but aside from the name of the library in the part of
directive ('lib1') and the fact that this test isn't conditional based on
whether uri-in-part-of is enabled, this test appears to be identical to
test_analyze_resolveDirectives_error_missingLibraryDirective. Am I missing
something?

[floitsch, 2017-06-09 12:32:35]

https://codereview.chromium.org/2931893004/diff/20001/pkg/analyzer/test/src/d...
File pkg/analyzer/test/src/dart/analysis/driver_test.dart (right):

https://codereview.chromium.org/2931893004/diff/20001/pkg/analyzer/test/src/d...
pkg/analyzer/test/src/dart/analysis/driver_test.dart:561:
test_analyze_resolveDirectives_error_partOfUnnamedLibrary_byName() async {
On 2017/06/08 19:54:23, Brian Wilkerson wrote:
> I'm probably blind, but aside from the name of the library in the part of
> directive ('lib1') and the fact that this test isn't conditional based on
> whether uri-in-part-of is enabled, this test appears to be identical to
> test_analyze_resolveDirectives_error_missingLibraryDirective. Am I missing
> something?

No. I just wrote this test first, and then had to go back and fix the failing
test above.
I didn't take the time to see if there were more differences. ("More tests:
great!"). You are right, though. The second test doesn't add anything.

Removed.

[floitsch, 2017-06-09 19:08:32]

Description was changed from

==========
Report an error when a part-of refers to an unnamed library.

Fixes #28522
BUG= http://dartbug.com/28522
==========

to

==========
Report an error when a part-of refers to an unnamed library.

Fixes #28522
BUG= http://dartbug.com/28522
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/377093841f1768537548e8cdb68b87dd3403b8dd
==========

[floitsch, 2017-06-09 19:08:34]

Committed patchset #3 (id:40001) manually as
377093841f1768537548e8cdb68b87dd3403b8dd (presubmit successful).