Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2533)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs

Issue 2931893002: More precise use of multiline state (Closed)
Patch Set: Fix test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs b/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
index 6bfb586ce35c6eb8a0fd9e5eaad91991af31c3b6..ca1524e558c51628e1a660208b714f2f7e611546 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
@@ -163,7 +163,8 @@ TEST_F('EditingTest', 'TextButNoSelectionChange', function() {
TEST_F('EditingTest', 'OneLineBreak', function() {
this.assertLineData(function() {/*!
- <div role="textbox" contenteditable>this is a<br>test</div>
+ <div role="textbox" contenteditable aria-multiline="true">
+ this is a<br>test</div>
*/},
[
{start: 0, end: 9, text: 'this is a'},
@@ -173,8 +174,8 @@ TEST_F('EditingTest', 'OneLineBreak', function() {
TEST_F('EditingTest', 'TwoLineBreaks', function() {
this.assertLineData(function() {/*!
- <div role="textbox" contenteditable>this is a<br><br>
- test</div>
+ <div role="textbox" contenteditable aria-multiline="true">
+ this is a<br><br>test</div>
*/},
[
{start: 0, end: 9, text: 'this is a'},
@@ -185,7 +186,7 @@ TEST_F('EditingTest', 'TwoLineBreaks', function() {
TEST_F('EditingTest', 'InitialBreaks', function() {
this.assertLineData(function() {/*!
- <div role="textbox" contenteditable><br><br><br>
+ <div role="textbox" contenteditable aria-multiline="true"><br><br><br>
this is a</div>
*/},
[
@@ -198,7 +199,7 @@ TEST_F('EditingTest', 'InitialBreaks', function() {
TEST_F('EditingTest', 'SingleCharacterLine', function() {
this.assertLineData(function() {/*!
- <div role="textbox" contenteditable>
+ <div role="textbox" contenteditable aria-multiline="true">
David Tseng 2017/07/01 01:17:40 This is a pretty bad example to do this. The conte
<div>this</div><br>
<div><br>
I<br>

Powered by Google App Engine
This is Rietveld 408576698