More precise use of multiline state

chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Include test fixture.
 GEN_INCLUDE(['../../testing/chromevox_next_e2e_test_base.js',
              '../../testing/assert_additions.js']);
 
 GEN_INCLUDE(['../../testing/mock_feedback.js']);
 
@@ skipping 145 matching lines @@
           .call(input.setSelection.bind(input, 5, 5))
           .expectBraille('text2 ed', {startIndex: 5, endIndex: 5})
           .expectSpeech('text2');
 
       mockFeedback.replay();
     });
 });
 
 TEST_F('EditingTest', 'OneLineBreak', function() {
   this.assertLineData(function() {/*!
-      <div role="textbox" contenteditable>this is a<br>test</div>
+      <div role="textbox" contenteditable aria-multiline="true">
+          this is a<br>test</div>
     */},
     [
       {start: 0, end: 9, text: 'this is a'},
       {start: 10, end: 14, text: 'test'}
     ]);
 });
 
 TEST_F('EditingTest', 'TwoLineBreaks', function() {
   this.assertLineData(function() {/*!
-      <div role="textbox" contenteditable>this is a<br><br>
-          test</div>
+      <div role="textbox" contenteditable aria-multiline="true">
+          this is a<br><br>test</div>
     */},
     [
       {start: 0, end: 9, text: 'this is a'},
       {start: 10, end: 10, text: ''},
       {start: 11, end: 15, text: 'test'},
     ]);
 });
 
 TEST_F('EditingTest', 'InitialBreaks', function() {
   this.assertLineData(function() {/*!
-      <div role="textbox" contenteditable><br><br><br>
+      <div role="textbox" contenteditable aria-multiline="true"><br><br><br>
         this is a</div>
     */},
     [
       {start: 0, end: 0, text: ''},
       {start: 1, end: 1, text: ''},
       {start: 2, end: 2, text: ''},
       {start: 3, end: 12, text: 'this is a'},
     ]);
 });
 
 TEST_F('EditingTest', 'SingleCharacterLine', function() {
   this.assertLineData(function() {/*!
-      <div role="textbox" contenteditable>
+      <div role="textbox" contenteditable aria-multiline="true">

[David Tseng, 2017/07/01 01:17:40]

This is a pretty bad example to do this. The contenteditable clearly has
multiple lines and no event listeners to intercept key events.

The practical result of this is that ChromeVox can no longer rely upon the
multiline attribute for anything in contenteditables.

I think what would be a better justification of this change is to try collecting
some stats of real world usage. How many pages have contenteditables with role
textbox and how many of them are single lined?

Also, even if a page author intercepts all key events, if I type enough text
into the content editable, it will wrap (making it a multi line value). A author
would have to go pretty far to make the content editable "single" lined.
I could also paste multiple lines into the contet editable.

So, basically an author would have to:
- intercept at least enter (key event)
- make the content editable not wrap
- intercept paste
- hope no one inserts text with a content script

         <div>this</div><br>
         <div><br>
             I<br>
             can test</div></div>
     */},
     [
       {start: 0, end: 4, text: 'this'},
       {start: 5, end: 5, text: ''},
       {start: 6, end: 6, text: ''},
       {start: 7, end: 8, text: 'I'},
@@ skipping 545 matching lines @@
     assertEquals(0, e1.startOffset);
     assertEquals(2, e1.endOffset);
 
     // Across paragraph selection with base line on anchor.
     e1 = new editing.EditableLine(thisIsATest, 5, hello, 2, true);
     assertEquals('is ', e1.text);
     assertEquals(0, e1.startOffset);
     assertEquals(3, e1.endOffset);
   })
 });