Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2931863002: Rename PasswordStoreProxyMac to PasswordStoreMac. (Closed)

Created:
3 years, 6 months ago by vasilii
Modified:
3 years, 6 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename PasswordStoreProxyMac to PasswordStoreMac. PasswordStoreProxyMac isn't a proxy anymore. BUG=466638 Review-Url: https://codereview.chromium.org/2931863002 Cr-Commit-Position: refs/heads/master@{#477998} Committed: https://chromium.googlesource.com/chromium/src/+/fbc2a7048aef0d8b5f37958dc7caad9188beb57d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -525 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/password_manager/password_store_mac.h View 4 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/password_manager/password_store_mac.cc View 7 chunks +10 lines, -10 lines 0 comments Download
A + chrome/browser/password_manager/password_store_mac_unittest.cc View 16 chunks +24 lines, -25 lines 0 comments Download
D chrome/browser/password_manager/password_store_proxy_mac.h View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/password_manager/password_store_proxy_mac.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/password_manager/password_store_proxy_mac_unittest.cc View 1 chunk +0 lines, -337 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
vasilii
Hi Vaclav, please review
3 years, 6 months ago (2017-06-08 14:58:42 UTC) #4
vabr (Chromium)
LGTM, good to see this! Vaclav
3 years, 6 months ago (2017-06-08 15:12:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931863002/1
3 years, 6 months ago (2017-06-08 15:18:17 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 16:49:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fbc2a7048aef0d8b5f37958dc7ca...

Powered by Google App Engine
This is Rietveld 408576698