Print Preview: Change getPrinterCapabilities to cr.sendWithPromise

chrome/test/data/webui/print_preview/print_preview_destination_search_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var ROOT_PATH = '../../../../../';
 
 GEN_INCLUDE(
         [ROOT_PATH + 'chrome/test/data/webui/polymer_browser_test_base.js']);
 
 /**
@@ skipping 84 matching lines @@
       return new Promise(function(resolve) {
         var listener = function(e) {
           resolve();
           element.removeEventListener(eventName, listener);
         };
 
         element.addEventListener(eventName, listener);
       });
     };
 
-    function mockSetupCall(destId, nativeLayerMock) {
-      assert (!cr.isChromeOS);
-      nativeLayerMock.setDestinationToWatch(destId);
-      var resolver = new PromiseResolver();
-
-      resolver.promise.then(
-          function(result) {
-            // Simulate the native layer dispatching capabilities.
-            var capsSetEvent =
-                new Event(print_preview.NativeLayer.EventType.CAPABILITIES_SET);
-            capsSetEvent.settingsInfo = result;
-            destinationStore_.onLocalDestinationCapabilitiesSet_(capsSetEvent);
-            expectTrue(nativeLayerMock.didGetCapabilitiesOnce(destId));
-          }.bind(this),
-          function() {
-            var failEvent = new Event(
-                print_preview.NativeLayer.EventType.GET_CAPABILITIES_FAIL);
-            failEvent.destinationId = destId;
-            destinationStore_.onGetCapabilitiesFail_(failEvent);
-            expectTrue(nativeLayerMock.didGetCapabilitiesOnce(destId));

[rbpotter, 2017/06/09 10:24:23]

I do not think we need this only-called-once check now that the local
destinations have the same TestBrowserProxy setup and callback checks
as the CrOS destinations. However, I can add it back again if desired.

[dpapad, 2017/06/09 17:59:11]

+1 on removing it.

-          }.bind(this));
-
-      return resolver;
-    };
-
     function requestSetup(destId, destinationSearch) {
       var origin = cr.isChromeOS ? print_preview.DestinationOrigin.CROS :
                                    print_preview.DestinationOrigin.LOCAL;
 
       var dest = new print_preview.Destination(destId,
           print_preview.DestinationType.LOCAL,
           origin,
           "displayName",
           print_preview.DestinationConnectionStatus.ONLINE);
 
@@ skipping 29 matching lines @@
 
     teardown(function() {
       Mock4JS.verifyAllMocks();
     });
 
     test('ResolutionFails', function() {
       var destId = "001122DEADBEEF";
       if (cr.isChromeOS) {
         nativeLayer_.setSetupPrinterResponse(true, { printerId: destId,
                                                      success: false,});
-        requestSetup(destId, destinationSearch_);
-        return nativeLayer_.whenCalled('setupPrinter').then(
-            function(actualDestId) {
-              assertEquals(destId, actualDestId);
-            });
       } else {
-        var resolver = mockSetupCall(destId, nativeLayer_);
-        requestSetup(destId, destinationSearch_);
-        resolver.reject(destId);
+        nativeLayer_.setLocalDestinationCapabilities(getCaps(), true);
       }
+      requestSetup(destId, destinationSearch_);
+      var callback = cr.isChromeOS ? 'setupPrinter' : 'getPrinterCapabilities';
+      return nativeLayer_.whenCalled(callback).then(
+          function(actualDestId) {
+            assertEquals(destId, actualDestId);
+          });
     });
 
     test('ReceiveSuccessfulSetup', function() {
       var destId = "00112233DEADBEEF";
       var response = {
         printerId: destId,
         capabilities: getCaps(),
         success: true,
       };
       if (cr.isChromeOS)
         nativeLayer_.setSetupPrinterResponse(false, response);
+      else
+        nativeLayer_.setLocalDestinationCapabilities(getCaps());
 
       var waiter = waitForEvent(
           destinationStore_,
           print_preview.DestinationStore.EventType.DESTINATION_SELECT);
-      if (cr.isChromeOS) {
-        requestSetup(destId, destinationSearch_);
-        return Promise.all([
-            nativeLayer_.whenCalled('setupPrinter'), waiter
-        ]).then(function(results) {
-          assertEquals(destId, results[0]);
-
-          // after setup succeeds and event arrives, the destination should
-          // be selected.
-          assertNotEquals(null, destinationStore_.selectedDestination);
-          assertEquals(destId, destinationStore_.selectedDestination.id);
-        });
-      } else { //!cr.isChromeOS
-        var resolver = mockSetupCall(destId, nativeLayer_);
-        requestSetup(destId, destinationSearch_);
-        resolver.resolve(response);
-        return waiter.then(function() {
-          // after setup succeeds, the destination should be selected.
-          assertNotEquals(null, destinationStore_.selectedDestination);
-          assertEquals(destId, destinationStore_.selectedDestination.id);
-        });
-      }
+      requestSetup(destId, destinationSearch_);
+      var callback = cr.isChromeOS ? 'setupPrinter' : 'getPrinterCapabilities';
+      return Promise.all([nativeLayer_.whenCalled(callback), waiter]).then(
+          function(results) {
+            assertEquals(destId, results[0]);
+            // after setup succeeds, the destination should be selected.
+            assertNotEquals(null, destinationStore_.selectedDestination);
+            assertEquals(destId, destinationStore_.selectedDestination.id);
+          });
     });
 
     if (cr.isChromeOS) {
       // The 'ResolutionFails' test covers this case for non-CrOS.
       test('ReceiveFailedSetup', function() {
         var destId = '00112233DEADBEEF';
         var response = {
           printerId: destId,
           capabilities: getCaps(),
           success: false,
@@ skipping 26 matching lines @@
       // Simulate a click.
       dest.onActivate_();
 
       // Verify that the destination has been selected.
       assertEquals(printerId, destinationStore_.selectedDestination.id);
     });
   });
 
   mocha.run();
 });