Print Preview: Change get*PrinterCapabilities to cr.sendWithPromise
Change all the get*PrinterCapabilities functions
(getPrinterCapabilities, getPrivetPrinterCapabilities,
getExtensionCapabilities) to cr.sendWithPromise. All share the same
function for failure (onGetCapabilitiesFail).
Change tests to work with the new system.
BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2931843003
Cr-Commit-Position: refs/heads/master@{#479489}
Committed: https://chromium.googlesource.com/chromium/src/+/03c1f4449fec6a5fe7406647023b0c8b6531444a
Description was changed from ========== Print Preview: Change getPrinterCapabilities to cr.sendWithPromise BUG=717296 ========== to ========== ...
3 years, 6 months ago
(2017-06-09 01:28:36 UTC)
#1
Description was changed from
==========
Print Preview: Change getPrinterCapabilities to cr.sendWithPromise
BUG=717296
==========
to
==========
Print Preview: Change getPrinterCapabilities to cr.sendWithPromise
BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
rbpotter
Description was changed from ========== Print Preview: Change getPrinterCapabilities to cr.sendWithPromise BUG=717296 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ...
3 years, 6 months ago
(2017-06-09 08:47:34 UTC)
#2
Description was changed from
==========
Print Preview: Change getPrinterCapabilities to cr.sendWithPromise
BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Print Preview: Change get*PrinterCapabilities to cr.sendWithPromise
Change all the get*PrinterCapabilities functions
(getPrinterCapabilities, getPrivetPrinterCapabilities,
getExtensionCapabilities) to cr.sendWithPromise. All share the same
function for failure (onGetCapabilitiesFail).
Change tests to work with the new system.
BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode1611 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1611: if (callback_id.empty()) { Here and in one other location ...
3 years, 6 months ago
(2017-06-09 10:24:23 UTC)
#8
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right):
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1611: if
(callback_id.empty()) {
Here and in one other location the capabilities error was being
triggered despite the fact that we reach this point only via a
printing call. It seems like it makes more sense to call a
privet printing fail at that point rather than a capabilities
error, which just checks if the destination was auto-filled and
then picks another one but does nothing to indicate or recover
from a printing fail.
If we want to keep the original behavior, could add a listener
for this privet printing failed event in the destination store and
handle it in the same way as the capabilities fetch failure.
https://codereview.chromium.org/2931843003/diff/40001/chrome/test/data/webui/...
File
chrome/test/data/webui/print_preview/print_preview_destination_search_test.js
(left):
https://codereview.chromium.org/2931843003/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/print_preview/print_preview_destination_search_test.js:124:
expectTrue(nativeLayerMock.didGetCapabilitiesOnce(destId));
I do not think we need this only-called-once check now that the local
destinations have the same TestBrowserProxy setup and callback checks
as the CrOS destinations. However, I can add it back again if desired.
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago
(2017-06-09 10:42:33 UTC)
#9
3 years, 6 months ago
(2017-06-09 10:42:34 UTC)
#10
Dry run: This issue passed the CQ dry run.
dpapad
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/resources/print_preview/data/destination_store.js#newcode679 chrome/browser/resources/print_preview/data/destination_store.js:679: /** @type {print_preview.DestinationOrigin} */ (origin))); Indent off by 2? ...
3 years, 6 months ago
(2017-06-09 17:59:11 UTC)
#11
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/print_preview/data/destination_store.js (right):
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/resource...
chrome/browser/resources/print_preview/data/destination_store.js:679: /** @type
{print_preview.DestinationOrigin} */ (origin)));
Indent off by 2?
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/print_preview/native_layer.js (right):
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/resource...
chrome/browser/resources/print_preview/native_layer.js:249: * @return
{!Promise<print_preview.PrinterCapabilitiesResponse>}
Can this be more specific?
!Promise<!print_preview.PrinterCapabilitiesResponse>
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/resource...
chrome/browser/resources/print_preview/native_layer.js:260: * @return
{!Promise<{"printer": !Object,
I don't recall needing to add double quotes within a type annotation. Are they
necessary?
Also this type is repeated here and in destination_store.js. Can we add a
typedef and reuse it from both files?
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right):
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1611: if
(callback_id.empty()) {
On 2017/06/09 at 10:24:23, rbpotter wrote:
> Here and in one other location the capabilities error was being
> triggered despite the fact that we reach this point only via a
> printing call. It seems like it makes more sense to call a
> privet printing fail at that point rather than a capabilities
> error, which just checks if the destination was auto-filled and
> then picks another one but does nothing to indicate or recover
> from a printing fail.
>
> If we want to keep the original behavior, could add a listener
> for this privet printing failed event in the destination store and
> handle it in the same way as the capabilities fetch failure.
Hm, I don't fully understand the implications here. At first glance, why do we
ever get an empty callback_id here? I see that we are passing "" at line 1639,
but is this temporary (until we convert more stuff to sendWithPromise)?
In theory all async requests from JS to C++ are backed by a Promise, and we
reject that promise, eliminating the need for "onPrivetPrintFailed" global JS
function.
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1816:
RejectJavascriptCallback(base::Value(callback_id), base::Value(printer_id));
Does it still make sense to pass the printer_id in the response? I was thinking
maybe not, since there is a direct association of request and response via the
Promise anyway.
https://codereview.chromium.org/2931843003/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/print_preview/native_layer_stub.js (right):
https://codereview.chromium.org/2931843003/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/print_preview/native_layer_stub.js:160: * @param {boolean
| undefined} reject Whether to reject the callback for
The proper way to define optional parameters is as follows:
@param {boolean?} opt_reject
https://codereview.chromium.org/2931843003/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/print_preview/native_layer_stub.js:167: {"response":
capabilities, "reject": reject});
Can we directly pass the Promise to be eventually returned to callers here?
localDestinationCapabilities_.set(
capabilities.printerId,
opt_reject ?
Promise.resolve(capabilities) :
Promise.reject(capabilities.printerId));
Then, inside the stub simply do:
getPrinterCapabilities: function(printerId) {
this.methodCalled('getPrinterCapabilities', printerId);
return this.localDestinationCapabilities_.get(printerId);
}
This reduces unnecessary intermediate data structures.
https://codereview.chromium.org/2931843003/diff/40001/chrome/test/data/webui/...
File
chrome/test/data/webui/print_preview/print_preview_destination_search_test.js
(left):
https://codereview.chromium.org/2931843003/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/print_preview/print_preview_destination_search_test.js:124:
expectTrue(nativeLayerMock.didGetCapabilitiesOnce(destId));
On 2017/06/09 at 10:24:23, rbpotter wrote:
> I do not think we need this only-called-once check now that the local
> destinations have the same TestBrowserProxy setup and callback checks
> as the CrOS destinations. However, I can add it back again if desired.
+1 on removing it.
rbpotter
Patchset #4 (id:60001) has been deleted
3 years, 6 months ago
(2017-06-14 01:15:14 UTC)
#12
Patchset #4 (id:60001) has been deleted
rbpotter
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
3 years, 6 months ago
(2017-06-14 01:17:14 UTC)
#13
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/441103)
3 years, 6 months ago
(2017-06-14 03:32:59 UTC)
#26
3 years, 6 months ago
(2017-06-14 03:55:08 UTC)
#29
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/print_preview/data/destination_store.js (right):
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/resource...
chrome/browser/resources/print_preview/data/destination_store.js:679: /** @type
{print_preview.DestinationOrigin} */ (origin)));
On 2017/06/09 17:59:11, dpapad wrote:
> Indent off by 2?
Done.
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/print_preview/native_layer.js (right):
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/resource...
chrome/browser/resources/print_preview/native_layer.js:249: * @return
{!Promise<print_preview.PrinterCapabilitiesResponse>}
On 2017/06/09 17:59:11, dpapad wrote:
> Can this be more specific?
>
> !Promise<!print_preview.PrinterCapabilitiesResponse>
Done.
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/resource...
chrome/browser/resources/print_preview/native_layer.js:260: * @return
{!Promise<{"printer": !Object,
On 2017/06/09 17:59:11, dpapad wrote:
> I don't recall needing to add double quotes within a type annotation. Are they
> necessary?
>
> Also this type is repeated here and in destination_store.js. Can we add a
> typedef and reuse it from both files?
Done.
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right):
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1611: if
(callback_id.empty()) {
On 2017/06/09 17:59:11, dpapad wrote:
> On 2017/06/09 at 10:24:23, rbpotter wrote:
> > Here and in one other location the capabilities error was being
> > triggered despite the fact that we reach this point only via a
> > printing call. It seems like it makes more sense to call a
> > privet printing fail at that point rather than a capabilities
> > error, which just checks if the destination was auto-filled and
> > then picks another one but does nothing to indicate or recover
> > from a printing fail.
> >
> > If we want to keep the original behavior, could add a listener
> > for this privet printing failed event in the destination store and
> > handle it in the same way as the capabilities fetch failure.
>
> Hm, I don't fully understand the implications here. At first glance, why do we
> ever get an empty callback_id here? I see that we are passing "" at line 1639,
> but is this temporary (until we convert more stuff to sendWithPromise)?
>
> In theory all async requests from JS to C++ are backed by a Promise, and we
> reject that promise, eliminating the need for "onPrivetPrintFailed" global JS
> function.
Was originally thinking it might be temporary and we could change
the print message to cr.sendWithPromise, then reject that promise
here if it failed. However I looked into this more and found that local
printing never actually sends a message back to JS except for in the
case of Extension/Privet print failures, which both call the global
"onPrivetPrintFailed" function. This is because the dialog gets closed
if the print job is successful. So I am not sure if it makes sense to
change print to sendWithPromise, since the dialog would be closed
either before the promise resolves or at around the same time,
depending on the type of printer.
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1816:
RejectJavascriptCallback(base::Value(callback_id), base::Value(printer_id));
On 2017/06/09 17:59:11, dpapad wrote:
> Does it still make sense to pass the printer_id in the response? I was
thinking
> maybe not, since there is a direct association of request and response via the
> Promise anyway.
Done.
https://codereview.chromium.org/2931843003/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/print_preview/native_layer_stub.js (right):
https://codereview.chromium.org/2931843003/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/print_preview/native_layer_stub.js:160: * @param {boolean
| undefined} reject Whether to reject the callback for
On 2017/06/09 17:59:11, dpapad wrote:
> The proper way to define optional parameters is as follows:
>
> @param {boolean?} opt_reject
Done.
https://codereview.chromium.org/2931843003/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/print_preview/native_layer_stub.js:167: {"response":
capabilities, "reject": reject});
On 2017/06/09 17:59:11, dpapad wrote:
> Can we directly pass the Promise to be eventually returned to callers here?
>
> localDestinationCapabilities_.set(
> capabilities.printerId,
> opt_reject ?
> Promise.resolve(capabilities) :
> Promise.reject(capabilities.printerId));
>
> Then, inside the stub simply do:
>
> getPrinterCapabilities: function(printerId) {
> this.methodCalled('getPrinterCapabilities', printerId);
> return this.localDestinationCapabilities_.get(printerId);
> }
>
> This reduces unnecessary intermediate data structures.
Done.
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago
(2017-06-14 05:11:58 UTC)
#30
3 years, 6 months ago
(2017-06-14 05:12:00 UTC)
#31
Dry run: This issue passed the CQ dry run.
dpapad
LGTM with nits. https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode1611 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1611: if (callback_id.empty()) { > Was originally ...
3 years, 6 months ago
(2017-06-14 17:19:36 UTC)
#32
LGTM with nits.
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right):
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1611: if
(callback_id.empty()) {
> Was originally thinking it might be temporary and we could change
> the print message to cr.sendWithPromise, then reject that promise
> here if it failed. However I looked into this more and found that local
> printing never actually sends a message back to JS except for in the
> case of Extension/Privet print failures, which both call the global
> "onPrivetPrintFailed" function. This is because the dialog gets closed
> if the print job is successful. So I am not sure if it makes sense to
> change print to sendWithPromise, since the dialog would be closed
> either before the promise resolves or at around the same time,
> depending on the type of printer.
Ok. Can we then eliminate (in a follow up CL) the global onPrivetPrintFailed
function using FireWebUIListener() as needed?
https://codereview.chromium.org/2931843003/diff/220001/chrome/browser/resourc...
File chrome/browser/resources/print_preview/native_layer.js (right):
https://codereview.chromium.org/2931843003/diff/220001/chrome/browser/resourc...
chrome/browser/resources/print_preview/native_layer.js:35: * capabilities:
print_preview.Cdd,
Should this be !print_preview.Cdd ?
https://codereview.chromium.org/2931843003/diff/220001/chrome/test/data/webui...
File chrome/test/data/webui/print_preview/print_preview_tests.js (right):
https://codereview.chromium.org/2931843003/diff/220001/chrome/test/data/webui...
chrome/test/data/webui/print_preview/print_preview_tests.js:45: * @param
{?print_preview.PrinterCapabilitiesResponse} Response parameters
@param {Type} paramName Description
Parameter name missing. Also since this is meant to be an optional param, use
the same "=" pattern as elsewhere in this CL.
https://codereview.chromium.org/2931843003/diff/220001/chrome/test/data/webui...
chrome/test/data/webui/print_preview/print_preview_tests.js:61: return
nativeLayer.whenCalled('getPrinters');
Nit:
return Promise.all([
nativeLayer.whenCalled('getPrinters'),
nativeLayer.whenCalled('getPrinterCapabilities'),
]);
https://codereview.chromium.org/2931843003/diff/220001/chrome/test/data/webui...
chrome/test/data/webui/print_preview/print_preview_tests.js:92: * @param {string
| undefined} printerName Defaults to an empty string.
Same here. Optional params are usually defined as follows
@param {string=} opt_printerName
rbpotter
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
3 years, 6 months ago
(2017-06-14 18:24:12 UTC)
#33
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode1611 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1611: if (callback_id.empty()) { On 2017/06/14 17:19:36, dpapad wrote: > ...
3 years, 6 months ago
(2017-06-14 18:28:26 UTC)
#35
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right):
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1611: if
(callback_id.empty()) {
On 2017/06/14 17:19:36, dpapad wrote:
> > Was originally thinking it might be temporary and we could change
> > the print message to cr.sendWithPromise, then reject that promise
> > here if it failed. However I looked into this more and found that local
> > printing never actually sends a message back to JS except for in the
> > case of Extension/Privet print failures, which both call the global
> > "onPrivetPrintFailed" function. This is because the dialog gets closed
> > if the print job is successful. So I am not sure if it makes sense to
> > change print to sendWithPromise, since the dialog would be closed
> > either before the promise resolves or at around the same time,
> > depending on the type of printer.
>
> Ok. Can we then eliminate (in a follow up CL) the global onPrivetPrintFailed
> function using FireWebUIListener() as needed?
Ok, will do.
https://codereview.chromium.org/2931843003/diff/220001/chrome/browser/resourc...
File chrome/browser/resources/print_preview/native_layer.js (right):
https://codereview.chromium.org/2931843003/diff/220001/chrome/browser/resourc...
chrome/browser/resources/print_preview/native_layer.js:35: * capabilities:
print_preview.Cdd,
On 2017/06/14 17:19:36, dpapad wrote:
> Should this be !print_preview.Cdd ?
Done. Needs to be !print_preview.Cdd as it is passed directly to
localizeCapabilities_.
https://codereview.chromium.org/2931843003/diff/220001/chrome/test/data/webui...
File chrome/test/data/webui/print_preview/print_preview_tests.js (right):
https://codereview.chromium.org/2931843003/diff/220001/chrome/test/data/webui...
chrome/test/data/webui/print_preview/print_preview_tests.js:45: * @param
{?print_preview.PrinterCapabilitiesResponse} Response parameters
On 2017/06/14 17:19:36, dpapad wrote:
> @param {Type} paramName Description
>
> Parameter name missing. Also since this is meant to be an optional param, use
> the same "=" pattern as elsewhere in this CL.
Done.
https://codereview.chromium.org/2931843003/diff/220001/chrome/test/data/webui...
chrome/test/data/webui/print_preview/print_preview_tests.js:61: return
nativeLayer.whenCalled('getPrinters');
On 2017/06/14 17:19:36, dpapad wrote:
> Nit:
>
> return Promise.all([
> nativeLayer.whenCalled('getPrinters'),
> nativeLayer.whenCalled('getPrinterCapabilities'),
> ]);
Done.
https://codereview.chromium.org/2931843003/diff/220001/chrome/test/data/webui...
chrome/test/data/webui/print_preview/print_preview_tests.js:92: * @param {string
| undefined} printerName Defaults to an empty string.
On 2017/06/14 17:19:36, dpapad wrote:
> Same here. Optional params are usually defined as follows
>
> @param {string=} opt_printerName
Done.
rbpotter
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode1611 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1611: if (callback_id.empty()) { On 2017/06/14 18:28:25, rbpotter wrote: > ...
3 years, 6 months ago
(2017-06-14 19:19:55 UTC)
#36
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right):
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1611: if
(callback_id.empty()) {
On 2017/06/14 18:28:25, rbpotter wrote:
> On 2017/06/14 17:19:36, dpapad wrote:
> > > Was originally thinking it might be temporary and we could change
> > > the print message to cr.sendWithPromise, then reject that promise
> > > here if it failed. However I looked into this more and found that local
> > > printing never actually sends a message back to JS except for in the
> > > case of Extension/Privet print failures, which both call the global
> > > "onPrivetPrintFailed" function. This is because the dialog gets closed
> > > if the print job is successful. So I am not sure if it makes sense to
> > > change print to sendWithPromise, since the dialog would be closed
> > > either before the promise resolves or at around the same time,
> > > depending on the type of printer.
> >
> > Ok. Can we then eliminate (in a follow up CL) the global onPrivetPrintFailed
> > function using FireWebUIListener() as needed?
>
> Ok, will do.
See followup here: https://codereview.chromium.org/2935303003/
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago
(2017-06-14 20:16:17 UTC)
#37
CQ is committing da patch. Bot data: {"patchset_id": 240001, "attempt_start_ts": 1497472085768300, "parent_rev": "2e986179979a89c8a2bdf55d139cd56baacd8573", "commit_rev": "03c1f4449fec6a5fe7406647023b0c8b6531444a"}
3 years, 6 months ago
(2017-06-14 20:32:32 UTC)
#42
CQ is committing da patch.
Bot data: {"patchset_id": 240001, "attempt_start_ts": 1497472085768300,
"parent_rev": "2e986179979a89c8a2bdf55d139cd56baacd8573", "commit_rev":
"03c1f4449fec6a5fe7406647023b0c8b6531444a"}
commit-bot: I haz the power
Description was changed from ========== Print Preview: Change get*PrinterCapabilities to cr.sendWithPromise Change all the get*PrinterCapabilities ...
3 years, 6 months ago
(2017-06-14 20:32:46 UTC)
#43
Message was sent while issue was closed.
Description was changed from
==========
Print Preview: Change get*PrinterCapabilities to cr.sendWithPromise
Change all the get*PrinterCapabilities functions
(getPrinterCapabilities, getPrivetPrinterCapabilities,
getExtensionCapabilities) to cr.sendWithPromise. All share the same
function for failure (onGetCapabilitiesFail).
Change tests to work with the new system.
BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Print Preview: Change get*PrinterCapabilities to cr.sendWithPromise
Change all the get*PrinterCapabilities functions
(getPrinterCapabilities, getPrivetPrinterCapabilities,
getExtensionCapabilities) to cr.sendWithPromise. All share the same
function for failure (onGetCapabilitiesFail).
Change tests to work with the new system.
BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2931843003
Cr-Commit-Position: refs/heads/master@{#479489}
Committed:
https://chromium.googlesource.com/chromium/src/+/03c1f4449fec6a5fe7406647023b...
==========
commit-bot: I haz the power
Committed patchset #10 (id:240001) as https://chromium.googlesource.com/chromium/src/+/03c1f4449fec6a5fe7406647023b0c8b6531444a
3 years, 6 months ago
(2017-06-14 20:32:48 UTC)
#44
Issue 2931843003: Print Preview: Change getPrinterCapabilities to cr.sendWithPromise
(Closed)
Created 3 years, 6 months ago by rbpotter
Modified 3 years, 6 months ago
Reviewers: dpapad
Base URL:
Comments: 28