Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2931843003: Print Preview: Change getPrinterCapabilities to cr.sendWithPromise (Closed)

Created:
3 years, 6 months ago by rbpotter
Modified:
3 years, 6 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Print Preview: Change get*PrinterCapabilities to cr.sendWithPromise Change all the get*PrinterCapabilities functions (getPrinterCapabilities, getPrivetPrinterCapabilities, getExtensionCapabilities) to cr.sendWithPromise. All share the same function for failure (onGetCapabilitiesFail). Change tests to work with the new system. BUG=717296 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2931843003 Cr-Commit-Position: refs/heads/master@{#479489} Committed: https://chromium.googlesource.com/chromium/src/+/03c1f4449fec6a5fe7406647023b0c8b6531444a

Patch Set 1 #

Patch Set 2 : Fix compilation, fix errors, fix tests #

Patch Set 3 : Cleanup #

Total comments: 20

Patch Set 4 : Address comments #

Patch Set 5 : Fix DCHECK bug #

Patch Set 6 : Fix privet printing bug #

Patch Set 7 : Add annotation for privet description #

Patch Set 8 : Remove extra arg #

Patch Set 9 : Fix test breakage #

Total comments: 8

Patch Set 10 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+499 lines, -611 lines) Patch
M chrome/browser/resources/print_preview/data/destination_store.js View 1 2 3 9 chunks +45 lines, -44 lines 0 comments Download
M chrome/browser/resources/print_preview/data/local_parsers.js View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/native_layer.js View 1 2 3 4 5 6 7 8 9 10 chunks +56 lines, -124 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/extension_printer_handler.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/extension_printer_handler.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc View 1 2 3 4 5 6 7 8 4 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 1 2 3 4 5 6 7 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 3 4 5 6 7 11 chunks +80 lines, -53 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/printer_handler.h View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/webui/print_preview/native_layer_stub.js View 1 2 3 7 chunks +28 lines, -35 lines 0 comments Download
M chrome/test/data/webui/print_preview/print_preview_destination_search_test.js View 1 2 3 3 chunks +21 lines, -55 lines 0 comments Download
M chrome/test/data/webui/print_preview/print_preview_tests.js View 1 2 3 4 5 6 7 8 9 41 chunks +255 lines, -280 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 44 (36 generated)
rbpotter
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode1611 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1611: if (callback_id.empty()) { Here and in one other location ...
3 years, 6 months ago (2017-06-09 10:24:23 UTC) #8
dpapad
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/resources/print_preview/data/destination_store.js#newcode679 chrome/browser/resources/print_preview/data/destination_store.js:679: /** @type {print_preview.DestinationOrigin} */ (origin))); Indent off by 2? ...
3 years, 6 months ago (2017-06-09 17:59:11 UTC) #11
rbpotter
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/resources/print_preview/data/destination_store.js#newcode679 chrome/browser/resources/print_preview/data/destination_store.js:679: /** @type {print_preview.DestinationOrigin} */ (origin))); On 2017/06/09 17:59:11, dpapad ...
3 years, 6 months ago (2017-06-14 03:55:08 UTC) #29
dpapad
LGTM with nits. https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode1611 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1611: if (callback_id.empty()) { > Was originally ...
3 years, 6 months ago (2017-06-14 17:19:36 UTC) #32
rbpotter
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode1611 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1611: if (callback_id.empty()) { On 2017/06/14 17:19:36, dpapad wrote: > ...
3 years, 6 months ago (2017-06-14 18:28:26 UTC) #35
rbpotter
https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/2931843003/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode1611 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1611: if (callback_id.empty()) { On 2017/06/14 18:28:25, rbpotter wrote: > ...
3 years, 6 months ago (2017-06-14 19:19:55 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931843003/240001
3 years, 6 months ago (2017-06-14 20:28:33 UTC) #41
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 20:32:48 UTC) #44
Message was sent while issue was closed.
Committed patchset #10 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/03c1f4449fec6a5fe7406647023b...

Powered by Google App Engine
This is Rietveld 408576698