Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2931833004: Always set the navigation pending item for page reload. (Closed)
Patch Set: only reload cases Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index ef6384d90059af5292aeafef2c81191fd5871596..81119c79aeaaf611c2d793f685663cb4f7c2829b 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -3762,6 +3762,15 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
return;
}
+ // If this is a reload initiated from the omnibox.
+ // TODO(crbug.com/730192): Add DCHECK to verify that whenever urlToLood is the
+ // same as the old url, the transition type is ui::PAGE_TRANSITION_RELOAD.
+ if (PageTransitionCoreTypeIs(transition, ui::PAGE_TRANSITION_RELOAD)) {
+ [[_model currentTab] navigationManager]->Reload(
+ web::ReloadType::NORMAL, true /* check_for_repost */);
+ return;
+ }
+
web::NavigationManager::WebLoadParams params(urlToLoad);
params.referrer = referrer;
params.transition_type = transition;

Powered by Google App Engine
This is Rietveld 408576698